From: Heiko Carstens <hca@linux.ibm.com>
To: "weiyongjun (A)" <weiyongjun1@huawei.com>
Cc: zhongbaisong <zhongbaisong@huawei.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Janosch Frank <frankja@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
kvm@vger.kernel.org, linux-s390@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] s390/protvirt: fix error return code in uv_info_init()
Date: Wed, 7 Apr 2021 15:06:57 +0200 [thread overview]
Message-ID: <YG2ucbm3YziNrD2l@osiris> (raw)
In-Reply-To: <0210417d-23df-1fdc-2af8-b2664ed2c484@huawei.com>
On Wed, Apr 07, 2021 at 08:48:19PM +0800, weiyongjun (A) wrote:
> > Fix to return a negative error code from the error handling
> > case instead of 0, as done elsewhere in this function.
> >
> > Reported-by: Hulk Robot <hulkci@huawei.com>
> > Signed-off-by: Baisong Zhong <zhongbaisong@huawei.com>
> > ---
> > arch/s390/kernel/uv.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/s390/kernel/uv.c b/arch/s390/kernel/uv.c
> > index cbfbeab57c3b..370f664580af 100644
> > --- a/arch/s390/kernel/uv.c
> > +++ b/arch/s390/kernel/uv.c
> > @@ -460,8 +460,10 @@ static int __init uv_info_init(void)
> > goto out_kobj;
> >
> > uv_query_kset = kset_create_and_add("query", NULL, uv_kobj);
> > - if (!uv_query_kset)
> > + if (!uv_query_kset) {
> > + rc = -ENOMEM;
> > goto out_ind_files;
> > + }
>
> Your patch is corrupted, please resend with correct format.
Fixed up, and applied anyway. Thanks.
next prev parent reply other threads:[~2021-04-07 13:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 12:38 [PATCH -next] s390/protvirt: fix error return code in uv_info_init() zhongbaisong
2021-04-07 12:45 ` weiyongjun (A)
2021-04-07 12:48 ` weiyongjun (A)
2021-04-07 13:06 ` Heiko Carstens [this message]
2021-04-13 14:15 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YG2ucbm3YziNrD2l@osiris \
--to=hca@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=frankja@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=weiyongjun1@huawei.com \
--cc=zhongbaisong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox