public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: Aaron Lewis <aaronlewis@google.com>
Cc: david.edmondson@oracle.com, jmattson@google.com, kvm@vger.kernel.org
Subject: Re: [PATCH v3 1/2] kvm: x86: Allow userspace to handle emulation errors
Date: Wed, 21 Apr 2021 17:52:11 +0000	[thread overview]
Message-ID: <YIBmS1rMr5vaE2b6@google.com> (raw)
In-Reply-To: <20210421162225.3924641-1-aaronlewis@google.com>

Please wait at least a day between versions to give everyone a chance to review
the latest information and digest other folks' comments.  Even a single day is
a bit too frequent in most cases, especially for a series where people are
actively commenting on the changes, as is the case here.  I.e. give the current
conversation a chance to run its course before spawning a new thread.  Exceptions
are few and far between, e.g. if you completely botched something and there's no
point in having people review the current versions.

Also, please include a cover letter with a synopsis of the delta between versions.
Without that, reviewers have no idea what's different in v1 vs. v2 vs. v3 vs. vN,
which increases the burden on reviewers.  The delta information is especially
helpful if other reviewers join the conversation at a later point.

On Wed, Apr 21, 2021, Aaron Lewis wrote:
> Add a fallback mechanism to the in-kernel instruction emulator that
> allows userspace the opportunity to process an instruction the emulator
> was unable to.  When the in-kernel instruction emulator fails to process
> an instruction it will either inject a #UD into the guest or exit to
> userspace with exit reason KVM_INTERNAL_ERROR.  This is because it does
> not know how to proceed in an appropriate manner.  This feature lets
> userspace get involved to see if it can figure out a better path
> forward.
> 
> Signed-off-by: Aaron Lewis <aaronlewis@google.com>

      parent reply	other threads:[~2021-04-21 17:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-21 16:22 [PATCH v3 1/2] kvm: x86: Allow userspace to handle emulation errors Aaron Lewis
2021-04-21 16:22 ` [PATCH v3 2/2] selftests: kvm: Allows " Aaron Lewis
2021-04-22 13:57   ` Jim Mattson
2021-04-26 14:39     ` Aaron Lewis
2021-04-21 17:52 ` Sean Christopherson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YIBmS1rMr5vaE2b6@google.com \
    --to=seanjc@google.com \
    --cc=aaronlewis@google.com \
    --cc=david.edmondson@oracle.com \
    --cc=jmattson@google.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox