From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C086FC43461 for ; Tue, 27 Apr 2021 21:58:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A79F7613B0 for ; Tue, 27 Apr 2021 21:58:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239377AbhD0V7Y (ORCPT ); Tue, 27 Apr 2021 17:59:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239364AbhD0V7O (ORCPT ); Tue, 27 Apr 2021 17:59:14 -0400 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3525BC06175F for ; Tue, 27 Apr 2021 14:58:31 -0700 (PDT) Received: by mail-pl1-x636.google.com with SMTP id a11so762663plh.3 for ; Tue, 27 Apr 2021 14:58:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=GM2oAi1eIassl2KE9QEB2DIOW4+0ysif8RFRhM2xzYI=; b=WG/aZBu2xYsBYP0PTRaptVMtN/fcTuR7BD/9Op2YIBWgCClIBBhHij0fZI/Cb8p2M8 B/vSq/QWoue5+UrK/zKcotuDhJqw/g203QjwVTfNJtgi0pJ5HOGjzAXGmcHdKkMa2iS0 olq9RVpkYDR51A55tjTQXTaOEauSqSiZZJ5LeyZsc9xcOCqryq9ZBHtv9CUhApCy2Op5 sZyhYk4anVC5X0xu5CE43QB6ZHtNJlQHV9bHIDEC7dK463503lZQkHfBt+XQHTCG1vpa /cUlv2iwHrTYDCXXfDtiqbZERz5udd9/Q8UumEhpHcThFv38Z4f3b4aog5RC98KCnLjU 3qmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=GM2oAi1eIassl2KE9QEB2DIOW4+0ysif8RFRhM2xzYI=; b=bMHtJeYeRGuClj7yWmCbVOfIeNpseWK8NLpcarD2tMolgNgw3eIAiGcx5wtD2MfF8x AVk9l1uyFoEJfB6LRHwZbjeZKgVyu30VrXlmssZb+nOkWzElXfERSFRrOpXL7F5SGjTU 7G/Q9j27SYbThts5DxBINZEDb7lfm/XVRSa2kJesJnyMtRZIBWGxZ3+wLDBoZD2cbXy+ czvm9wQEkI4n40b4XDfWMRyEgdIP0fdtXCMsbBXXKvt74dxS6k+B82/WEGdYQZdBNNwC PN369mBs9zOTcFdwxWaIENazBfHc9kx+JNqhtU/WAPs2bYbgtBX+TK1E/kvgkuBz4fjd PoVA== X-Gm-Message-State: AOAM531bP/f/KedDLGnPhBXVl0/dYrZa60P2Sw05RW1bAz/U+NvPHd1j 6Nh062ZUI0AL7YKd/Q/atIVlcw== X-Google-Smtp-Source: ABdhPJwoNIoYndE80IPG3x6wK5IIiV+e7UukRLYi6vTtjvv6ZEjgO5qlKYaLKDVs8gBqYQDd2r5/vQ== X-Received: by 2002:a17:90b:4c8b:: with SMTP id my11mr388997pjb.201.1619560710674; Tue, 27 Apr 2021 14:58:30 -0700 (PDT) Received: from google.com (240.111.247.35.bc.googleusercontent.com. [35.247.111.240]) by smtp.gmail.com with ESMTPSA id 14sm2682634pfv.33.2021.04.27.14.58.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Apr 2021 14:58:30 -0700 (PDT) Date: Tue, 27 Apr 2021 21:58:26 +0000 From: Sean Christopherson To: Reiji Watanabe Cc: Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/4] KVM: x86: Tie Intel and AMD behavior for MSR_TSC_AUX to guest CPU model Message-ID: References: <20210423223404.3860547-1-seanjc@google.com> <20210423223404.3860547-4-seanjc@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, Apr 26, 2021, Reiji Watanabe wrote: > > There is also a kernel bug lurking; vgetcpu_cpu_init() doesn't check > > X86_FEATURE_RDPID and will fail to initialize MSR_TSC_AUX if RDPID is supported > > but RDTSCP is not, and __getcpu() uses RDPID. I'll verify that's broken and > > send a patch for that one too. > > I don't find vgetcpu_cpu_init() or __getcpu() in > https://github.com/torvalds/linux. > I would assume you meant setup_getcpu() and vdso_read_cpunode() instead (?). Ya, I was looking at an old kernel when I typed that up. Bug is still there though :-)