From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6437BC48BD1 for ; Fri, 11 Jun 2021 15:22:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3FC73613EE for ; Fri, 11 Jun 2021 15:22:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231270AbhFKPYk (ORCPT ); Fri, 11 Jun 2021 11:24:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38046 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229517AbhFKPYi (ORCPT ); Fri, 11 Jun 2021 11:24:38 -0400 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5D86C061574 for ; Fri, 11 Jun 2021 08:22:40 -0700 (PDT) Received: by mail-pj1-x102b.google.com with SMTP id k7so5876342pjf.5 for ; Fri, 11 Jun 2021 08:22:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=zDELvCcEl/roHFnu9m1VHxPMUFNGvlvXPDIVOdM9ikI=; b=XdxzAeVCHwLfBHz8cwbbMnqGUVYc1UhOgikbpV/QktNU4q2i1dFv67gEJlMo9w9vqk 6DmFYF01OeGiGvCjs66NOqLz1lA2x/t0gDvPQea3oBfwg8118Oqzcm2z/WWrn6BYo8o1 f1Ud2F18s4JEDyeimOlfyCEjTy7xPV3cWAEPHezp7t4OPoEzT4CAZTzr+4bYZKMELOkL gF6s/tyAoCfzLFMi5Z5KY0ESOyToo7l5owGWE4mSM9Abc42rNL12HVlHneqXsfQO8XOT 9EB7GFITgOryG+zIJJ+YeVMdsA8FM2E+z6yNqIELqrzPUHz03D3xJ0Ln96v8RhXI2FLS xeRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=zDELvCcEl/roHFnu9m1VHxPMUFNGvlvXPDIVOdM9ikI=; b=nxD6gfhaMk4+Np5O7whf/IGJ7PBRQOFv2gqbswV4+rJSCGpXpAjVxs5QDsIAJqVfdQ hXe4O0b4D2c7ONZxAPG4R+DQWBukzoDNnymJm0nrJTdME4xASJsdL/kx2bs8yXWyDDC7 +sKth0cU9IRrmEK0TJ14l7a3OviCU4REw1hL3nOYbvaDS+Nv9WLLqg9vVNt3HOWJCxgW bH20XPKtxJPf9qrCU4M08iplLHBwGw9nyNc1hZvm1AtIBWYSAmXYI+S2Y7BzlMIhPd9s xI8Wmu3pc8pp1i8mO1c/g4PlneQl5IkWyvJAqhmUV5CS0rEe+6IuMLBN++XzVQA0kUsJ RcBg== X-Gm-Message-State: AOAM531YKtOWc9Ci87VfPOMMFLpMrepoqP+Taug4M/g0mMytydMpCdy1 fz2+hfKL867c2utI2JdvV+DLTQ== X-Google-Smtp-Source: ABdhPJzZQDlzV2QvMony8EkHB9Mw0VaryeIHIZB8UdY/fsJL2Env/3MvBvtiqwkxgZuKQaWtek2cKw== X-Received: by 2002:a17:90a:4a12:: with SMTP id e18mr5070251pjh.213.1623424960138; Fri, 11 Jun 2021 08:22:40 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id r6sm10590322pjm.12.2021.06.11.08.22.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Jun 2021 08:22:39 -0700 (PDT) Date: Fri, 11 Jun 2021 15:22:35 +0000 From: Sean Christopherson To: Erdem Aktas Cc: "Yamahata, Isaku" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , x86 , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, isaku.yamahata@gmail.com, Sean Christopherson , Xiaoyao Li , Kai Huang , Isaku Yamahata Subject: Re: [RFC PATCH 64/67] KVM: TDX: Add "basic" support for building and running Trust Domains Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, Jun 10, 2021, Erdem Aktas wrote: > Hi Isaku, > > I know you are going to submit a set of new patch series so here are > few feedbacks thatI have encounter: > > > KVM_TDX_INIT_VM has a parameter that user space VMM can provide the > CPUID entries but it is not clear if any of those entries are > mandatory. If userspace VMM does not provide guest_supported_xcr0 and > guest_supported_xss, TDX init will fail as their default values are > set to 0. > > It is expected but would be nice to document (or return an error > message with more information) that KVM_CAP_X2APIC_API and > KVM_IRQCHIP_SPLIT CAPS need to be enabled. > > When CPUID entries are queried from KVM (using > KVM_GET_SUPPORTED_CPUID) and provided back to the KVM_TDX_INIT_VM, > the default GPAW size requires 5 level SEPT but KVM still tries to > create 4 level SEPT and fails to add private pages. Error messages are > also not very helpful to figure out what was happening. Please trim your replies and try to avoid top-posting. Thanks for the input! https://people.kernel.org/tglx/notes-about-netiquette