From: Heiko Carstens <hca@linux.ibm.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: Halil Pasic <pasic@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
linux-s390@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH] virtio/s390: get rid of open-coded kvm hypercall
Date: Mon, 21 Jun 2021 21:42:08 +0200 [thread overview]
Message-ID: <YNDrkOhjRiaBv34p@osiris> (raw)
In-Reply-To: <87lf73nsqj.fsf@redhat.com>
On Mon, Jun 21, 2021 at 05:27:00PM +0200, Cornelia Huck wrote:
> On Mon, Jun 21 2021, Heiko Carstens <hca@linux.ibm.com> wrote:
>
> > do_kvm_notify() and __do_kvm_notify() are an (exact) open-coded variant
> > of kvm_hypercall3(). Therefore simply make use of kvm_hypercall3(),
> > and get rid of duplicated code.
> >
> > Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
> > ---
> > drivers/s390/virtio/virtio_ccw.c | 30 ++++--------------------------
> > 1 file changed, 4 insertions(+), 26 deletions(-)
> >
>
> Hm, I wonder why I didn't use kvm_hypercall3 in the first place. It's in
> a header, and therefore should be independent of kvm being configured.
>
> I don't think there's anything else virtio-ccw in flight at the moment,
> so maybe you can apply this one directly?
Yes, sure.
> Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Thank you!
next prev parent reply other threads:[~2021-06-21 19:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 14:45 [PATCH] virtio/s390: get rid of open-coded kvm hypercall Heiko Carstens
2021-06-21 15:27 ` Cornelia Huck
2021-06-21 19:42 ` Heiko Carstens [this message]
2021-06-21 17:05 ` Christian Borntraeger
2021-06-21 23:50 ` Halil Pasic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNDrkOhjRiaBv34p@osiris \
--to=hca@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=gor@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=pasic@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox