From: Sean Christopherson <seanjc@google.com>
To: Tom Lendacky <thomas.lendacky@amd.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Peter Gonda <pgonda@google.com>,
Brijesh Singh <brijesh.singh@amd.com>
Subject: Re: [PATCH 0/7] KVM: x86: guest MAXPHYADDR and C-bit fixes
Date: Thu, 24 Jun 2021 22:15:31 +0000 [thread overview]
Message-ID: <YNUEA8n61WO89voW@google.com> (raw)
In-Reply-To: <7e3a90c0-75a1-b8fe-dbcf-bda16502ace9@amd.com>
On Thu, Jun 24, 2021, Tom Lendacky wrote:
> On 6/24/21 12:39 PM, Tom Lendacky wrote:
> >
> >
> > On 6/24/21 12:31 PM, Sean Christopherson wrote:
> >> On Thu, Jun 24, 2021, Tom Lendacky wrote:
> >>>>
> >>>> Here's an explanation of the physical address reduction for bare-metal and
> >>>> guest.
> >>>>
> >>>> With MSR 0xC001_0010[SMEE] = 0:
> >>>> No reduction in host or guest max physical address.
> >>>>
> >>>> With MSR 0xC001_0010[SMEE] = 1:
> >>>> - Reduction in the host is enumerated by CPUID 0x8000_001F_EBX[11:6],
> >>>> regardless of whether SME is enabled in the host or not. So, for example
> >>>> on EPYC generation 2 (Rome) you would see a reduction from 48 to 43.
> >>>> - There is no reduction in physical address in a legacy guest (non-SEV
> >>>> guest), so the guest can use a 48-bit physical address
> >>
> >> So the behavior I'm seeing is either a CPU bug or user error. Can you verify
> >> the unexpected #PF behavior to make sure I'm not doing something stupid?
> >
> > Yeah, I saw that in patch #3. Let me see what I can find out. I could just
> > be wrong on that myself - it wouldn't be the first time.
>
> From patch #3:
> SVM: KVM: CPU #PF @ rip = 0x409ca4, cr2 = 0xc0000000, pfec = 0xb
> KVM: guest PTE = 0x181023 @ GPA = 0x180000, level = 4
> KVM: guest PTE = 0x186023 @ GPA = 0x181000, level = 3
> KVM: guest PTE = 0x187023 @ GPA = 0x186000, level = 2
> KVM: guest PTE = 0xffffbffff003 @ GPA = 0x187000, level = 1
> SVM: KVM: GPA = 0x7fffbffff000
>
> I think you may be hitting a special HT region that is at the top 12GB of
> the 48-bit memory range and is reserved, even for GPAs. Can you somehow
> get the test to use an address below 0xfffd_0000_0000? That would show
> that bit 47 is valid for the legacy guest while staying out of the HT region.
I can make that happen.
I assume "HT" is HyperTransport?
next prev parent reply other threads:[~2021-06-24 22:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 23:05 [PATCH 0/7] KVM: x86: guest MAXPHYADDR and C-bit fixes Sean Christopherson
2021-06-23 23:05 ` [PATCH 1/7] KVM: x86: Use guest MAXPHYADDR from CPUID.0x8000_0008 iff TDP is enabled Sean Christopherson
2021-06-23 23:05 ` [PATCH 2/7] KVM: x86: Use kernel's x86_phys_bits to handle reduced MAXPHYADDR Sean Christopherson
2021-06-23 23:05 ` [PATCH 3/7] KVM: x86: Truncate reported guest MAXPHYADDR to C-bit if SEV is supported Sean Christopherson
2021-06-23 23:05 ` [PATCH 4/7] KVM: x86/mmu: Do not apply HPA (memory encryption) mask to GPAs Sean Christopherson
2021-06-23 23:05 ` [PATCH 5/7] KVM: VMX: Refactor 32-bit PSE PT creation to avoid using MMU macro Sean Christopherson
2021-06-23 23:05 ` [PATCH 6/7] KVM: x86/mmu: Bury 32-bit PSE paging helpers in paging_tmpl.h Sean Christopherson
2021-06-23 23:05 ` [PATCH 7/7] KVM: x86/mmu: Use separate namespaces for guest PTEs and shadow PTEs Sean Christopherson
2021-06-24 7:43 ` [PATCH 0/7] KVM: x86: guest MAXPHYADDR and C-bit fixes Paolo Bonzini
2021-06-24 16:30 ` Tom Lendacky
2021-06-24 16:36 ` Tom Lendacky
2021-06-24 17:31 ` Sean Christopherson
2021-06-24 17:39 ` Tom Lendacky
2021-06-24 22:07 ` Tom Lendacky
2021-06-24 22:15 ` Sean Christopherson [this message]
2021-06-24 22:19 ` Tom Lendacky
2021-06-24 23:47 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNUEA8n61WO89voW@google.com \
--to=seanjc@google.com \
--cc=brijesh.singh@amd.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=pgonda@google.com \
--cc=thomas.lendacky@amd.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox