Re: [PATCH 1/7] vfio: Create vfio_fs_type with inode per device

Peter Xu
2021-08-10T22:18:38Z

On Tue, Aug 10, 2021 at 03:16:14PM -0600, Alex Williamson wrote:
> On Tue, 10 Aug 2021 14:49:45 -0400
> Peter Xu <peterx@redhat.com> wrote:
>
> > On Tue, Aug 10, 2021 at 03:57:29PM +0100, Christoph Hellwig wrote:
> > > On Tue, Aug 10, 2021 at 08:52:54AM -0600, Alex Williamson wrote:
> > > > On Tue, 10 Aug 2021 10:43:29 +0200
> > > > Christoph Hellwig <hch@infradead.org> wrote:
> > > >
> > > > > > + * XXX Adopt the following when available:
> > > > > > + * https://lore.kernel.org/lkml/20210309155348.974875-1-hch@lst.de/
> > > > >
> > > > > No need for this link.
> > > >
> > > > Is that effort dead? I've used the link several times myself to search
> > > > for progress, so it's been useful to me. Thanks,
> > >
> > > No, but it seems odd to have reference to an old patchset in the kernel
> > > tree.
> >
> > I learn from the reference too. Maybe move into commit message? Thanks,
>
> TBH, I'm ok if it's "odd" if it's useful. Right here we have two
> instances of it being useful. I don't think that two lines of comment
> is excessive and we can always remove it when we either make the
> conversion or give up on it. Moving it to the commit log would just
> bury it to be pointless.
>
> I don't have a more concise, current, or future-proof way to describe
> the todo item than this link (ok, ok, I could s/lkml/r/ for 3 less
> chars :-P). Thanks,

Yep, fine by me - either by keeping it in the code, commit message, or in cover
letter, as it's still an useful reference before that series got merged. Thanks,

--
Peter Xu