Re: [PATCH 3/7] vfio/pci: Use vfio_device_unmap_mapping_range()

Alex Williamson
2021-08-10T20:51:27Z

On Tue, 10 Aug 2021 15:02:10 -0400
Peter Xu <peterx@redhat.com> wrote:

> On Tue, Aug 10, 2021 at 10:53:50AM +0200, Christoph Hellwig wrote:
> > On Thu, Aug 05, 2021 at 11:07:35AM -0600, Alex Williamson wrote:
> > > +static void vfio_pci_zap_bars(struct vfio_pci_device *vdev)
> > > {
> > > + vfio_device_unmap_mapping_range(&vdev->vdev,
> > > + VFIO_PCI_INDEX_TO_OFFSET(VFIO_PCI_BAR0_REGION_INDEX),
> > > + VFIO_PCI_INDEX_TO_OFFSET(VFIO_PCI_ROM_REGION_INDEX) -
> > > + VFIO_PCI_INDEX_TO_OFFSET(VFIO_PCI_BAR0_REGION_INDEX));
> >
> > Maybe make this a little more readable by having local variables:
>
> Or just pass in unmap_mapping_range(start=0, len=0)? As unmap_mapping_range()
> understands len==0 as "to the end of file". Thanks,

But we're not actually trying to unmap the entire device fd, we're only
targeting the ranges of it that correspond to standard MMIO resources
of the device. Our vma-to-pfn function for vfio-pci also only knows
how to lookup vmas in this range. If there were mmap'able regions
outside of this, for example provided by vendor specific extensions, we
a) don't generically know if they're related to the device itself or
some supporting information managed in software (ex. IGD OpRegion) and
b) don't know how to lookup the pfn to remap them when MMIO is
re-enabled.

I don't think we have any such extensions today, but we might with
vfio-pci-core and we'd need to figure out how to include those regions
in some future work. Thanks,

Alex