Re: [PATCH Part1 RFC v4 03/36] x86/sev: Add support for hypervisor feature VMGEXIT

Brijesh Singh
2021-08-10T13:39:45Z

On 8/10/21 6:22 AM, Borislav Petkov wrote:
>
> SVM_VMGEXIT_HV_FEATURES
>

Noted.

>>
>> +/* Bitmap of SEV features supported by the hypervisor */
>> +u64 sev_hv_features __section(".data..ro_after_init") = 0;
>
> __ro_after_init

Noted.

>
>> diff --git a/arch/x86/kernel/sev.c b/arch/x86/kernel/sev.c
>> index 66b7f63ad041..540b81ac54c9 100644
>> --- a/arch/x86/kernel/sev.c
>> +++ b/arch/x86/kernel/sev.c
>> @@ -96,6 +96,9 @@ struct ghcb_state {
>> static DEFINE_PER_CPU(struct sev_es_runtime_data*, runtime_data);
>> DEFINE_STATIC_KEY_FALSE(sev_es_enable_key);
>>
>> +/* Bitmap of SEV features supported by the hypervisor */
>> +EXPORT_SYMBOL(sev_hv_features);
>
> Why is this exported and why not a _GPL export?
>

I was thinking that some driver may need it in future, but nothing in my
series needs it yet. I will drop it and we can revisit it later.

-Brijesh