Re: [PATCH v3 3/7] nitro_enclaves: Add fix for the kernel-doc report

George-Aurelian Popescu
2021-08-30T15:53:49Z

On Fri, Aug 27, 2021 at 06:49:26PM +0300, Andra Paraschiv wrote:
> Fix the reported issue from the kernel-doc script, to have a comment per
> identifier.
>
> Signed-off-by: Andra Paraschiv <andraprs@amazon.com>
> ---
> Changelog
>
> v1 -> v2
>
> * Update comments for send / receive buffer sizes for the NE PCI device.
>
> v2 -> v3
>
> * Move changelog after the "---" line.
> ---
> drivers/virt/nitro_enclaves/ne_pci_dev.h | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/virt/nitro_enclaves/ne_pci_dev.h b/drivers/virt/nitro_enclaves/ne_pci_dev.h
> index 8bfbc66078185..6e9f28971a4e0 100644
> --- a/drivers/virt/nitro_enclaves/ne_pci_dev.h
> +++ b/drivers/virt/nitro_enclaves/ne_pci_dev.h
> @@ -1,6 +1,6 @@
> /* SPDX-License-Identifier: GPL-2.0 */
> /*
> - * Copyright 2020 Amazon.com, Inc. or its affiliates. All Rights Reserved.
> + * Copyright 2020-2021 Amazon.com, Inc. or its affiliates. All Rights Reserved.
> */
>
> #ifndef _NE_PCI_DEV_H_
> @@ -84,9 +84,13 @@
> */
>
> /**
> - * NE_SEND_DATA_SIZE / NE_RECV_DATA_SIZE - 240 bytes for send / recv buffer.
> + * NE_SEND_DATA_SIZE - Size of the send buffer, in bytes.
> */
> #define NE_SEND_DATA_SIZE (240)
> +
> +/**
> + * NE_RECV_DATA_SIZE - Size of the receive buffer, in bytes.
> + */
> #define NE_RECV_DATA_SIZE (240)
>
> /**
> --
> 2.20.1 (Apple Git-117)
>

Reviewed-by: George-Aurelian Popescu <popegeo@amazon.com>

Looks good,
George