Re: [PATCH v3 7/7] nitro_enclaves: Add fixes for checkpatch blank line reports

George-Aurelian Popescu
2021-08-30T15:45:28Z

On Fri, Aug 27, 2021 at 06:49:30PM +0300, Andra Paraschiv wrote:
> Remove blank lines that are not necessary, fixing the checkpatch script
> reports. While at it, add a blank line after the switch default block,
> similar to the other parts of the codebase.
>
> Signed-off-by: Andra Paraschiv <andraprs@amazon.com>
> ---
> Changelog
>
> v1 -> v2
>
> * No codebase changes, it was split from the patch 3 in the v1 of the
> patch series.
>
> v2 -> v3
>
> * Move changelog after the "---" line.
> ---
> samples/nitro_enclaves/ne_ioctl_sample.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/samples/nitro_enclaves/ne_ioctl_sample.c b/samples/nitro_enclaves/ne_ioctl_sample.c
> index 6a60990b2e202..765b131c73190 100644
> --- a/samples/nitro_enclaves/ne_ioctl_sample.c
> +++ b/samples/nitro_enclaves/ne_ioctl_sample.c
> @@ -185,7 +185,6 @@ static int ne_create_vm(int ne_dev_fd, unsigned long *slot_uid, int *enclave_fd)
> return 0;
> }
>
> -
> /**
> * ne_poll_enclave_fd() - Thread function for polling the enclave fd.
> * @data: Argument provided for the polling function.
> @@ -560,8 +559,8 @@ static int ne_add_vcpu(int enclave_fd, unsigned int *vcpu_id)
>
> default:
> printf("Error in add vcpu [%m]\n");
> -
> }
> +
> return rc;
> }
>
> --
> 2.20.1 (Apple Git-117)
>

Reviewed-by: George-Aurelian Popescu <popegeo@amazon.com>

Nice,
George