Re: [PATCH v3 1/7] nitro_enclaves: Enable Arm64 support

Paraschiv, Andra-Irina
2021-08-30T18:30:33Z

On 30/08/2021 18:59, George-Aurelian Popescu wrote:
> On Fri, Aug 27, 2021 at 06:49:24PM +0300, Andra Paraschiv wrote:
>> Update the kernel config to enable the Nitro Enclaves kernel driver for
>> Arm64 support.
>>
>> Signed-off-by: Andra Paraschiv <andraprs@amazon.com>
>> Acked-by: Stefano Garzarella <sgarzare@redhat.com>
>> ---
>> Changelog
>>
>> v1 -> v2
>>
>> * No changes.
>>
>> v2 -> v3
>>
>> * Move changelog after the "---" line.
>> ---
>> drivers/virt/nitro_enclaves/Kconfig | 8 ++------
>> 1 file changed, 2 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/virt/nitro_enclaves/Kconfig b/drivers/virt/nitro_enclaves/Kconfig
>> index 8c9387a232df8..f53740b941c0f 100644
>> --- a/drivers/virt/nitro_enclaves/Kconfig
>> +++ b/drivers/virt/nitro_enclaves/Kconfig
>> @@ -1,17 +1,13 @@
>> # SPDX-License-Identifier: GPL-2.0
>> #
>> -# Copyright 2020 Amazon.com, Inc. or its affiliates. All Rights Reserved.
>> +# Copyright 2020-2021 Amazon.com, Inc. or its affiliates. All Rights Reserved.
>>
>> # Amazon Nitro Enclaves (NE) support.
>> # Nitro is a hypervisor that has been developed by Amazon.
>>
>> -# TODO: Add dependency for ARM64 once NE is supported on Arm platforms. For now,
>> -# the NE kernel driver can be built for aarch64 arch.
>> -# depends on (ARM64 || X86) && HOTPLUG_CPU && PCI && SMP
>> -
>> config NITRO_ENCLAVES
>> tristate "Nitro Enclaves Support"
>> - depends on X86 && HOTPLUG_CPU && PCI && SMP
>> + depends on (ARM64 || X86) && HOTPLUG_CPU && PCI && SMP
>> help
>> This driver consists of support for enclave lifetime management
>> for Nitro Enclaves (NE).
>> --
>> 2.20.1 (Apple Git-117)
>>
> Reviewed-by: George-Aurelian Popescu <popegeo@amazon.com>
>

Thanks, George, for review.

Greg, let me know if other updates are needed for the patch series.
Otherwise, please include the patches in the char-misc tree and we can
target the current merge window, for v5.15. Thank you.

Andra