From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C272C83027 for ; Thu, 2 Sep 2021 16:40:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 231BA6109E for ; Thu, 2 Sep 2021 16:40:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346469AbhIBQl3 (ORCPT ); Thu, 2 Sep 2021 12:41:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346450AbhIBQl1 (ORCPT ); Thu, 2 Sep 2021 12:41:27 -0400 Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E02AC061575 for ; Thu, 2 Sep 2021 09:40:29 -0700 (PDT) Received: by mail-pg1-x531.google.com with SMTP id e7so2574179pgk.2 for ; Thu, 02 Sep 2021 09:40:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=j/QFpIwVpnWHaDYhXpnYGfEufg38ONfVKj0utdXFYrE=; b=cO8MvTjt4ahIeaQT++QeHOxEjuxb4vhu+5nhUb+3UqskIA5/KzG1Y4ew3P50DH/FJa NFnzfHm43h85a/tpR7za4bWzSiMvBtCEeTcxBUzd70h1YgpEMhayj/aQYlZCHJYAAu9A 6cCs6Lc9hoD+l8TSxhM9BEyRtYbluqc7SXllIn+oGYjyIJ6sjwV9/L0Vuibax/IwFhhJ 2bkWzlidprGak3I8fajgJ+rshi2H8AvxP+0PxkAqARA0AKzqzSmv/bH3pIhHguOT85Jh xYn85EobHuhEA7tKbEU++vjxQNN8Itz3JMXCjJsCgWLG0gBy47+/rX5ERVlIUgh6uPnT zuiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=j/QFpIwVpnWHaDYhXpnYGfEufg38ONfVKj0utdXFYrE=; b=skq4oR0YFw5bd57PawK85uOqDTnoyJzIHfHFMRYhUA5ECi66pifAvRcLF3Ck4a3CBe 7bjuSgrPUG2jCVtVYPU0ZYrjo8oiztbShO+zi3Ec+SqPq+JTAfjXFVXeW7mWN56Tbnyw btpteEzgYBw8bmftNDy7vLtGfiC2yT8mC8yj9eHOR/GzrFzRBP3EKwv1V6gwHd6LCIGU e4XJ5VDBMCXVekp6glCLRMlqFo03KqVot8K+4qUSHHuWYj0hj7iAMCkIvT79EJAOVmWc 54eSsNHnAfJygGfJv0Ry1fS5JmZOG9GV/M90L6Q+FPFosKU47cCyV3XTxt33RwFL8vz2 zhTg== X-Gm-Message-State: AOAM532AvWprUa4psL2YlRpe99wvwCyNsN5YLIjwKzFweGG+GgYAu0HG wyYJecCOJmdSni6n/EqdYQbrl1ulYOekng== X-Google-Smtp-Source: ABdhPJw1aIXjCFXU5zBhNxENfGz2Eto823JxV39HrLV/YNU7hZHSwdn8d7TGr2WuRNFnPCDO3Zugjw== X-Received: by 2002:aa7:9e4d:0:b0:3f8:6326:a038 with SMTP id z13-20020aa79e4d000000b003f86326a038mr4283516pfq.73.1630600828542; Thu, 02 Sep 2021 09:40:28 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id q12sm2839726pfj.153.2021.09.02.09.40.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Sep 2021 09:40:28 -0700 (PDT) Date: Thu, 2 Sep 2021 16:40:24 +0000 From: Sean Christopherson To: Vitaly Kuznetsov Cc: Peter Xu , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Paolo Bonzini , kernel test robot Subject: Re: [PATCH] KVM: Drop unused kvm_dirty_gfn_harvested() Message-ID: References: <20210901230506.13362-1-peterx@redhat.com> <87y28flyxj.fsf@vitty.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87y28flyxj.fsf@vitty.brq.redhat.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, Sep 02, 2021, Vitaly Kuznetsov wrote: > Peter Xu writes: > > > Drop the unused function as reported by test bot. > > Your subject line says "Drop unused kvm_dirty_gfn_harvested()" while in > reallity you drop "kvm_dirty_gfn_invalid()". Heh, Peter already sent v2[*]. Though that's a good reminder that it's helpful to reviewers to respond to your own patch if there's a fatal mistake and you're going to immediately post a new version. For tiny patches it's not a big deal, but for larger patches it can avoid wasting reviewers' time. https://lkml.kernel.org/r/20210901230904.15164-1-peterx@redhat.com