From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0CABC433EF for ; Fri, 3 Sep 2021 16:25:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D42ED61051 for ; Fri, 3 Sep 2021 16:25:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349953AbhICQ0D (ORCPT ); Fri, 3 Sep 2021 12:26:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349851AbhICQ0D (ORCPT ); Fri, 3 Sep 2021 12:26:03 -0400 Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F6BBC061575 for ; Fri, 3 Sep 2021 09:25:03 -0700 (PDT) Received: by mail-pg1-x530.google.com with SMTP id g184so6027147pgc.6 for ; Fri, 03 Sep 2021 09:25:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=MuUVKGuzhcnw475fxR/h4MUJO7/8nCYvBhM/dqOqGY8=; b=a5qp69RtKWOpDgVoJpcbKeFp4fHb3dpctDXalKWvk9x0mZvk5wTr//5DY4W0LTXZ59 vU5wMjKNFAB0/sDDpjwVsbJ4UXu/E2SC9wtVAJILZ1WqCW57WPTvS811boyUOcKLnupz I2kI7S/7Jx+p7ysFlAQ8Bk0f32XV/Wgfd5pc2KNXWsbPFtW/zZzsLy+9AIBf3ax5Whe4 ainrZ1m/2ggdSr2qgoL9bZdwdbT8xhMYN2ptG6vhbY6UwyHgNzZF0m2p2aU2S7yS3Ud6 QZLl3jg1c50P5Qdz/R9pcZQm507HQ549CZa8imyuzhAyXGSpxkZVOZ79HKfZakgPHrm3 PE7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=MuUVKGuzhcnw475fxR/h4MUJO7/8nCYvBhM/dqOqGY8=; b=rhnk7m70bbBfRJOP3Ycd/H3eSnS4vFC3g1I/iSzxyN7/YwnsEXTS74OgJVK4j80T+/ tB68Op24Q2OKT/zgL7SCX5rkJrBRpwXikyoauKdJB29OlNdc6UMlX03E3ANLw54AwpMs TT2KovjkouiGgPbcUtQyJrT1Zdc0bqGXpGy7WcIEGRLaeZHX7rkcF/8g3UjLfqZCH6Tf TKH/uQZ3LQdWzaTZAjlT/eBwcZuIC7brTCjjJOle7TV6WoVA8gVX65xQuFvlCgOye4cH oM07z24QVs7YlpmCDd2AvDN8b6yvwomBEHE2Gep3iizS/hkvBkr/5HXIaUD3cnlLzaO+ DMxw== X-Gm-Message-State: AOAM531SlfXN6Z0rRvN7/FWelQgGcASJVpwr2RQTKzX/hIB9UOcoRgE9 GNRZDcaa8G7cXVg1AapH9dl0dw== X-Google-Smtp-Source: ABdhPJwopWhVnbj64wyd76GFU8+hftQz9LsUECQ7yePVtwZeoENrkbJy4he1stiIW/KKmLPf5rlayA== X-Received: by 2002:a65:63d0:: with SMTP id n16mr4261048pgv.432.1630686302332; Fri, 03 Sep 2021 09:25:02 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id q18sm6086348pfj.46.2021.09.03.09.25.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Sep 2021 09:25:01 -0700 (PDT) Date: Fri, 3 Sep 2021 16:24:57 +0000 From: Sean Christopherson To: Vitaly Kuznetsov Cc: kvm@vger.kernel.org, Paolo Bonzini , Wanpeng Li , Jim Mattson , "Dr. David Alan Gilbert" , Nitesh Narayan Lal , Lai Jiangshan , Maxim Levitsky , Eduardo Habkost , linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 7/8] KVM: Pre-allocate cpumasks for kvm_make_all_cpus_request_except() Message-ID: References: <20210903075141.403071-1-vkuznets@redhat.com> <20210903075141.403071-8-vkuznets@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210903075141.403071-8-vkuznets@redhat.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Fri, Sep 03, 2021, Vitaly Kuznetsov wrote: > Allocating cpumask dynamically in zalloc_cpumask_var() is not ideal. > Allocation is somewhat slow and can (in theory and when CPUMASK_OFFSTACK) > fail. kvm_make_all_cpus_request_except() already disables preemption so > we can use pre-allocated per-cpu cpumasks instead. > > Signed-off-by: Vitaly Kuznetsov > --- Reviewed-by: Sean Christopherson