From: Sean Christopherson <seanjc@google.com>
To: Joerg Roedel <joro@8bytes.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>,
x86@kernel.org, Brijesh Singh <brijesh.singh@amd.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
Joerg Roedel <jroedel@suse.de>
Subject: Re: [PATCH v4 1/5] KVM: SVM: Get rid of set_ghcb_msr() and *ghcb_msr_bits() functions
Date: Wed, 13 Oct 2021 22:07:19 +0000 [thread overview]
Message-ID: <YWdYlzeJ0zUpXQma@google.com> (raw)
In-Reply-To: <20210929155330.5597-2-joro@8bytes.org>
On Wed, Sep 29, 2021, Joerg Roedel wrote:
> From: Joerg Roedel <jroedel@suse.de>
>
> Replace the get_ghcb_msr_bits() function with macros and open code the
> GHCB MSR setters with hypercall specific helper macros and functions.
> This will avoid preserving any previous bits in the GHCB-MSR and
> improves code readability.
>
> Also get rid of the set_ghcb_msr() function and open-code it at its
> call-sites for better code readability.
>
> Suggested-by: Sean Christopherson <seanjc@google.com>
> Signed-off-by: Joerg Roedel <jroedel@suse.de>
> Reviewed-by: Sean Christopherson <seanjc@google.com>
> Signed-off-by: Sean Christopherson <seanjc@google.com>
I suspect my SoB got picked up accidentally. If the intent was to attribute some
code snippets via Co-developed-by, feel free to just drop my SoB.
next prev parent reply other threads:[~2021-10-13 22:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 15:53 [PATCH v4 0/5] KVM: SVM: Add initial GHCB protocol version 2 support Joerg Roedel
2021-09-29 15:53 ` [PATCH v4 1/5] KVM: SVM: Get rid of set_ghcb_msr() and *ghcb_msr_bits() functions Joerg Roedel
2021-10-13 22:07 ` Sean Christopherson [this message]
2021-09-29 15:53 ` [PATCH v4 2/5] KVM: SVM: Add helper to generate GHCB MSR version info, and drop macro Joerg Roedel
2021-09-29 15:53 ` [PATCH v4 3/5] KVM: SVM: Add support to handle AP reset MSR protocol Joerg Roedel
2021-10-13 22:04 ` Sean Christopherson
2021-10-20 12:32 ` Joerg Roedel
2021-09-29 15:53 ` [PATCH v4 4/5] KVM: SVM: Add support for Hypervisor Feature support " Joerg Roedel
2021-09-29 15:53 ` [PATCH v4 5/5] KVM: SVM: Increase supported GHCB protocol version Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWdYlzeJ0zUpXQma@google.com \
--to=seanjc@google.com \
--cc=brijesh.singh@amd.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=jroedel@suse.de \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=thomas.lendacky@amd.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox