From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87D0BC4332F for ; Tue, 2 Nov 2021 16:54:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 70E4860F45 for ; Tue, 2 Nov 2021 16:54:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234978AbhKBQ5N (ORCPT ); Tue, 2 Nov 2021 12:57:13 -0400 Received: from mail.skyhub.de ([5.9.137.197]:52284 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234954AbhKBQ5F (ORCPT ); Tue, 2 Nov 2021 12:57:05 -0400 Received: from zn.tnic (p200300ec2f0f6200599060f0a067c463.dip0.t-ipconnect.de [IPv6:2003:ec:2f0f:6200:5990:60f0:a067:c463]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 46E391EC0532; Tue, 2 Nov 2021 17:54:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1635872069; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=XRnIinnL4tOnsAL/GsMC8vW8ZfXO/hpxLuI1GtroUw0=; b=MkIi5voWdAAqnJnlNQK6bNu9R7cztziHTaU/XPDf0ZKy0BqKKb1BQ3RuzDIFFXHy9EJP83 lb8sQGtpdAFvET5XpRXx283CSabxdd1se7RVnQ+RMaimeIJVnDCNa3vkNqD8JkEkKV3iVn j67HJZb2nQ1KtMFypPkKcJjVwQmjdIA= Date: Tue, 2 Nov 2021 17:54:29 +0100 From: Borislav Petkov To: Brijesh Singh Cc: x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, Thomas Gleixner , Ingo Molnar , Joerg Roedel , Tom Lendacky , "H. Peter Anvin" , Ard Biesheuvel , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Jim Mattson , Andy Lutomirski , Dave Hansen , Sergio Lopez , Peter Gonda , Peter Zijlstra , Srinivas Pandruvada , David Rientjes , Dov Murik , Tobin Feldman-Fitzthum , Michael Roth , Vlastimil Babka , "Kirill A . Shutemov" , Andi Kleen , "Dr . David Alan Gilbert" , tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, Borislav Petkov Subject: Re: [PATCH v6 15/42] x86/sev: Remove do_early_exception() forward declarations Message-ID: References: <20211008180453.462291-1-brijesh.singh@amd.com> <20211008180453.462291-16-brijesh.singh@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20211008180453.462291-16-brijesh.singh@amd.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Fri, Oct 08, 2021 at 01:04:26PM -0500, Brijesh Singh wrote: > From: Borislav Petkov > > There's a perfectly fine prototype in the asm/setup.h header. Use it. > > No functional changes. > > Signed-off-by: Borislav Petkov > Signed-off-by: Brijesh Singh > --- > arch/x86/kernel/sev.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) Right, for the next and all future submissions, it is a lot easier if you put all fixes and cleanups and code reorganizations at the beginning of the patchset. Because then they can simply get applied earlier - they're useful cleanups and fixes, after all - and this way you'll unload some of the patches quicker and have to deal with a smaller set. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette