From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 080C6C433F5 for ; Thu, 4 Nov 2021 20:08:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DF6FB6120F for ; Thu, 4 Nov 2021 20:08:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232124AbhKDUKp (ORCPT ); Thu, 4 Nov 2021 16:10:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231998AbhKDUKo (ORCPT ); Thu, 4 Nov 2021 16:10:44 -0400 Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C1BFC061714 for ; Thu, 4 Nov 2021 13:08:06 -0700 (PDT) Received: by mail-pf1-x42e.google.com with SMTP id h74so6919888pfe.0 for ; Thu, 04 Nov 2021 13:08:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=FCy7XmM3hO8fuNRRbZcDcJH+zhxWlYN4gDh9J8+Gr8Y=; b=i5FCB5yRnjsLmIeeLD+iM/48P6iRRBb5/VRgshHlVonSkwBfqOn7mKOOpkzAWa3d+X PKSQ3LKxLmU5TahEA0iAsYFe0/FgMn9qDEgQkQEqi5mAczxFwc1Cn8dBnQS3Hv0y+CnZ hJDpKn8/cUzWWP643aGY1oRkLzdX767kG/i9NUqhtJxYNm+XoN9nlkNUzMzXe8yzKVEF duEfBqvALTNuvmh1IrSc/nyUEA6tzE+2IzaryS3bHVoBmOsDqouXb6PH/74iv7ttaB2U s4AL14g2cyov6EqiKyVn48Z/2pU7KF2XOeY+qTvKKtuXPmDbmtZy7QpAeDO8olzGq95w rzoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FCy7XmM3hO8fuNRRbZcDcJH+zhxWlYN4gDh9J8+Gr8Y=; b=pggqLEnio19R5pRU/0HyY/4ZrQxwNO+pxQhSsVR/yhY0Bd7GAOr7w9YZa0iIvGng/O bSt+6g49X4YYWEWgF6Ym2YaGCFzDmCFjrdCRbFnEF4jjwi/eJ12zQQD3vAWGbvbKEjBB sU3l9c1Suh6V9PUS73nqhZWQG5bhCXG6n/5jfZH5zCm5oRyv7M62oYbGNqtbnWEVS0OS d3Cv/S+AITHaph8ezWuetLuc93KMB02tlUyrCBeO1YtUf50oCrjavUEIoYOpVobecYwG KlEV8B3HX0bixwmFx+L6M83votmerz0Fj8AQCj+s06UBSMbMKnOkUxcYUyHlPwCYoH4R ylYA== X-Gm-Message-State: AOAM531vbVRkivXvMMHYvKoIWLP/S8gUBcYBOCdk1tQtCwkU5cu5vTZw VdXkmavPLneMgChBwUFxAIdzl6QODcPhSw== X-Google-Smtp-Source: ABdhPJw1QIFV3CAI2UcbFZ2VrNW++pdmjxY1ykPw3mNFNIEDqRH5ndwZEhZedIX0vx5gIhpYebrvWA== X-Received: by 2002:a63:c4e:: with SMTP id 14mr10917845pgm.454.1636056485715; Thu, 04 Nov 2021 13:08:05 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id h1sm5941243pfi.168.2021.11.04.13.08.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Nov 2021 13:08:05 -0700 (PDT) Date: Thu, 4 Nov 2021 20:08:01 +0000 From: Sean Christopherson To: "Durrant, Paul" Cc: Paul Durrant , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel Subject: Re: [PATCH] KVM: x86: Make sure KVM_CPUID_FEATURES really are KVM_CPUID_FEATURES Message-ID: References: <20211104183020.4341-1-paul@xen.org> <90c513d31a1b41daae1a642d2f5c72b0@EX13D32EUC003.ant.amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <90c513d31a1b41daae1a642d2f5c72b0@EX13D32EUC003.ant.amazon.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, Nov 04, 2021, Durrant, Paul wrote: > > -----Original Message----- > > From: Sean Christopherson > > Sent: 04 November 2021 19:23 > > To: Paul Durrant > > Cc: kvm@vger.kernel.org; linux-kernel@vger.kernel.org; Durrant, Paul ; Paolo > > Bonzini ; Vitaly Kuznetsov ; Wanpeng Li > > ; Jim Mattson ; Joerg Roedel > > Subject: RE: [EXTERNAL] [PATCH] KVM: x86: Make sure KVM_CPUID_FEATURES really are KVM_CPUID_FEATURES > > > > On Thu, Nov 04, 2021, Paul Durrant wrote: > > > From: Paul Durrant > > > > > > Currently when kvm_update_cpuid_runtime() runs, it assumes that the > > > KVM_CPUID_FEATURES leaf is located at 0x40000001. This is not true, > > > however, if Hyper-V support is enabled. In this case the KVM leaves will > > > be offset. > > > > > > This patch introdues as new 'kvm_cpuid_base' field into struct > > > kvm_vcpu_arch to track the location of the KVM leaves and function > > > kvm_update_cpuid_base() (called from kvm_update_cpuid_runtime()) to locate > > > the leaves using the 'KVMKVMKVM\0\0\0' signature. Adjustment of > > > KVM_CPUID_FEATURES will hence now target the correct leaf. > > > > > > Signed-off-by: Paul Durrant > > > --- > > > Cc: Paolo Bonzini > > > Cc: Sean Christopherson > > > Cc: Vitaly Kuznetsov > > > Cc: Wanpeng Li > > > Cc: Jim Mattson > > > Cc: Joerg Roedel > > > > scripts/get_maintainer.pl is your friend :-) > > That's what I used, but thought it prudent to trim the list to just KVM reviewers. Ah, yeah, I run get_maintainer.pl with "--pattern-depth=1" when I'm sending KVM patches/series. That tells the script to stop recursing once its found a match.