From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99389C433F5 for ; Fri, 5 Nov 2021 01:05:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 72F8661106 for ; Fri, 5 Nov 2021 01:05:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231270AbhKEBIf (ORCPT ); Thu, 4 Nov 2021 21:08:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230493AbhKEBIf (ORCPT ); Thu, 4 Nov 2021 21:08:35 -0400 Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 901E6C061714 for ; Thu, 4 Nov 2021 18:05:56 -0700 (PDT) Received: by mail-pf1-x436.google.com with SMTP id x131so2254687pfc.12 for ; Thu, 04 Nov 2021 18:05:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=G/nhaOd9Dv5dMVPfxGxOacbJh3HbdybN9D3Bt3gtDl4=; b=nvfkNvU5Z8xadZEfrQs+mun09ht1fvHcLrH2DxUG/3DX7gUnwMzAJkexDG2eYTXZcT nXC0KbqPvC1tK0JQgs5hCtnmTYToVQpMf8nCU56R48NFvVb6s3m/Ngv/UjYCmArWyqT5 p0SUqwKjeQQxCQt0zc0As36KIH4BAIyfNYMeM36s0WzO5Q1J/xrc07u8scp9QxgFseUx dQ59ZAkYjl9GQ/mNW/WJt9rhnODEtXi5DZG6vgO1qHgTfVwOKU3kDPsIgbbN9rzZyOjx 2mxK9OAGR8TorHdShQM7kemuuxLfv77EOifqsz29EGFHH4GQs7sBLdkOTDN1ZVWUEahZ b+Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=G/nhaOd9Dv5dMVPfxGxOacbJh3HbdybN9D3Bt3gtDl4=; b=apAVoX1RnIrR1MbCwQdUXXtB0LeKheaT/sX2m6Y1HSZjDXA5vlNltUIgBWZiSTWJ9d 1Zfn5F2+Sr+JpgpXwZWOkSBcft1Gt62JeolFUMUjZG3QV+qu6PfjBmMKj/iKqefFkoud mZvWR8KbTepSfaVJKQ9F8jYEJ3CAiGSbzLwmPSHOhIHi7RjWNsGH1abUXCaFc9IGX+c1 cPQ89owy/Bzi3Y+lUNUjQH6QCyvG1pvzIdFYrVJyHU9IOk62vNnvSqUxigVqpE1KPCVY KC5/wQZ/O5rq6oeoOYfYLFrhhatsfJYXLvv2+E+spJPmxHYR9D+shaO66v65wVkJzT5c WgWg== X-Gm-Message-State: AOAM532y/wU2jX+ZxcvWr+VqQ9FKbpV0IaB5k/tObJupd4c0qbexlEBk WfKSS4nr3DZPf36Lmkvzrv7tRw== X-Google-Smtp-Source: ABdhPJxRK/fTi3PW003l6+S9tkKhBsOPyaIXk2qUrZkoR1F5QCgcD/FeTTDil/grcsUm+sPO+IkX/A== X-Received: by 2002:a05:6a00:c94:b0:480:fcc2:bb2c with SMTP id a20-20020a056a000c9400b00480fcc2bb2cmr37089927pfv.30.1636074355284; Thu, 04 Nov 2021 18:05:55 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id u22sm4846371pfi.78.2021.11.04.18.05.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Nov 2021 18:05:54 -0700 (PDT) Date: Fri, 5 Nov 2021 01:05:50 +0000 From: Sean Christopherson To: Vitaly Kuznetsov Cc: kvm@vger.kernel.org, Paolo Bonzini , Wanpeng Li , Jim Mattson , Maxim Levitsky , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 3/4] KVM: nVMX: Track whether changes in L0 require MSR bitmap for L2 to be rebuilt Message-ID: References: <20211013142258.1738415-1-vkuznets@redhat.com> <20211013142258.1738415-4-vkuznets@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211013142258.1738415-4-vkuznets@redhat.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, Oct 13, 2021, Vitaly Kuznetsov wrote: > diff --git a/arch/x86/kvm/vmx/vmx.h b/arch/x86/kvm/vmx/vmx.h > index 592217fd7d92..2cdf66e6d1b0 100644 > --- a/arch/x86/kvm/vmx/vmx.h > +++ b/arch/x86/kvm/vmx/vmx.h > @@ -148,6 +148,15 @@ struct nested_vmx { > bool need_vmcs12_to_shadow_sync; > bool dirty_vmcs12; > > + /* > + * Indicates whether MSR bitmap for L2 needs to be rebuilt due to > + * changes in MSR bitmap for L1 or switching to a different L2. Note, > + * this flag can only be used reliably in conjunction with a paravirt L1 > + * which informs L0 whether any changes to MSR bitmap for L2 were done > + * on its side. > + */ > + bool msr_bitmap_force_recalc; Belated bikeshedding... What about need_msr_bitmap_recalc to follow the above need_vmcs12_to_shadow_sync? > + > /* > * Indicates lazily loaded guest state has not yet been decached from > * vmcs02. > -- > 2.31.1 >