From: Sean Christopherson <seanjc@google.com>
To: Like Xu <like.xu.linux@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] KVM: x86: Copy kvm_pmu_ops by value to eliminate layer of indirection
Date: Fri, 5 Nov 2021 15:36:51 +0000 [thread overview]
Message-ID: <YYVPkxVeQO4VFGCZ@google.com> (raw)
In-Reply-To: <YYVODdVEc/deNP8p@google.com>
On Fri, Nov 05, 2021, Sean Christopherson wrote:
> On Wed, Nov 03, 2021, Like Xu wrote:
> I would also say land this memcpy() above kvm_ops_static_call_update(), then the
> enabling patch can do the static call updates in kvm_ops_static_call_update()
> instead of adding another helper.
Ugh, kvm_ops_static_call_update() is defined in kvm_host.h. That's completely
unnecessary, it should have exactly one caller, kvm_arch_hardware_setup(). As a
prep match, move kvm_ops_static_call_update() to x86.c, then it can reference the
pmu ops.
next prev parent reply other threads:[~2021-11-05 15:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 7:03 [PATCH 0/3] Use static_call for kvm_pmu_ops Like Xu
2021-11-03 7:03 ` [PATCH 1/3] KVM: x86: Copy kvm_pmu_ops by value to eliminate layer of indirection Like Xu
2021-11-05 15:30 ` Sean Christopherson
2021-11-05 15:36 ` Sean Christopherson [this message]
2021-11-08 9:26 ` Like Xu
2021-11-08 9:23 ` Like Xu
2021-11-03 7:03 ` [PATCH 2/3] KVM: x86: Introduce definitions to support static calls for kvm_pmu_ops Like Xu
2021-11-05 15:48 ` Sean Christopherson
2021-11-08 9:31 ` Like Xu
2021-11-08 15:41 ` Sean Christopherson
2021-11-03 7:03 ` [PATCH 3/3] KVM: x86: Use static calls to reduce kvm_pmu_ops overhead Like Xu
2021-11-03 12:08 ` Yao Yuan
2021-11-04 8:14 ` Like Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYVPkxVeQO4VFGCZ@google.com \
--to=seanjc@google.com \
--cc=bp@alien8.de \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=like.xu.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox