From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 461C1C433EF for ; Mon, 6 Dec 2021 15:52:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1390245AbhLFPzC (ORCPT ); Mon, 6 Dec 2021 10:55:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357615AbhLFPwf (ORCPT ); Mon, 6 Dec 2021 10:52:35 -0500 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82D36C036FAA for ; Mon, 6 Dec 2021 07:37:48 -0800 (PST) Received: by mail-pj1-x1030.google.com with SMTP id f18-20020a17090aa79200b001ad9cb23022so150466pjq.4 for ; Mon, 06 Dec 2021 07:37:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=7HzwmvjWwTv0FeXPfbk2piEjvWmlmu/Ix95bAO30KVA=; b=ZhuBW1c4dJPnblkwVVq7/i5JD1acaN3vKRPqk1vt1l4/1WVncLZ6/XF7i5mu75gzgu gjeCchw5SEdKY9IS6B7CPAfcmRrUtycY7KuXQmFjBHQHAkwiOcZJ9z0v/+YNWbTW74ju WW96J+3JEIUppGf6QeHbGWa7GVsgIexlxyh9hOk48GZohQPBwAtQkqiajM6rP2eObXpU BB9FK4L4OBLFpwyu9xrfcQ8X7jt5+ieR5WZzveGHAm+q8YpxPYGnxSwBq7pubQ1wuMhA A0WTx//Jdi0jZnVSCUhuNTOI/Ivk6mePXx6gLqDkkdRd+Kgm/eFjcy+0vGQqU+5gDD/C DlVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7HzwmvjWwTv0FeXPfbk2piEjvWmlmu/Ix95bAO30KVA=; b=K3agPRpmS4W21PiH2RTAFGF0idSDgGfpv8OAtU9PDs35t08ZwDmdY4+WcyI20kwANm eIAASqnNC3e24kZbBZB086nDun3SjhsgaIkuxSALwlcH+IA4ViOF/StZ6RSBKfw6XaXp 3xWz3pKB5U+HlfcFncUy0pjio5ayw2gNK4rxVaRSmbmEPX/x9xvkzmHMRuMjvdgr3iLY ONiyda44KmlQC8vTZRNPhgNBBETrJo8ATgq38enFpyPPhQ1PQ8YsYm8f75Q/AgXlLlzR HSjp7QetCq7pmsvgCcIiyMRyh/qNn9Z9qJwBD3LDz6itnB1TVIPDW8TKIhWGhehoeN+L 3zAA== X-Gm-Message-State: AOAM530AfFgAP3aMXPpC9coPHzF6rMGc/zDtgPknUDBl7216bx1XTciv kiET6EacA9APsvcKEPJED5To2TOwmSJ5zQ== X-Google-Smtp-Source: ABdhPJwcn3YT+bEUgsZ2X+gC+fgtI4ggBTfe1/BDgoKckLhZ5wuo1mJvX1iNXW4oitVJUGRb6dnE1Q== X-Received: by 2002:a17:90b:4c03:: with SMTP id na3mr37953644pjb.62.1638805067801; Mon, 06 Dec 2021 07:37:47 -0800 (PST) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id lr6sm11226043pjb.0.2021.12.06.07.37.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Dec 2021 07:37:47 -0800 (PST) Date: Mon, 6 Dec 2021 15:37:43 +0000 From: Sean Christopherson To: Ameer Hamza Cc: vkuznets@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, pbonzini@redhat.com, wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com Subject: Re: [PATCH v2] KVM: x86: fix for missing initialization of return status variable Message-ID: References: <87ee6q6r1p.fsf@redhat.com> <20211206102403.10797-1-amhamza.mgc@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211206102403.10797-1-amhamza.mgc@gmail.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, Dec 06, 2021, Ameer Hamza wrote: > If undefined ioctl number is passed to the kvm_vcpu_ioctl_device_attr > function, it should return with error status. No, if anything KVM should do KVM_BUG_ON() and return -EIO, because @ioctl is completely KVM controlled. But I'd personally prefer we leave it as is, there's one call site that very clearly invokes the helper with only the three ioctls. It's not a strong preference though.