From: Sean Christopherson <seanjc@google.com>
To: Zhenzhong Duan <zhenzhong.duan@intel.com>
Cc: kvm@vger.kernel.org, pbonzini@redhat.com
Subject: Re: [PATCH v2] x86: Assign a canonical address before execute invpcid
Date: Wed, 12 Jan 2022 18:23:01 +0000 [thread overview]
Message-ID: <Yd8chbAyJA1XB9bY@google.com> (raw)
In-Reply-To: <20220112025535.430455-1-zhenzhong.duan@intel.com>
On Wed, Jan 12, 2022, Zhenzhong Duan wrote:
> Accidently we see pcid test falied as INVPCID_DESC[127:64] is
> uninitialized before execute invpcid.
>
> According to Intel spec: "#GP If INVPCID_TYPE is 0 and the linear
> address in INVPCID_DESC[127:64] is not canonical."
>
> By zeroing the whole invpcid_desc structure, ensure the address
> canonical and reserved bit zero in desc.
The changelog should also note the opportunistic change from "unsigned long"
to "u64". It's all too easy to forget that they're equivalent due to this being
64-bit only.
Reviewed-by: Sean Christopherson <seanjc@google.com>
prev parent reply other threads:[~2022-01-12 18:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-12 2:55 [PATCH v2] x86: Assign a canonical address before execute invpcid Zhenzhong Duan
2022-01-12 18:23 ` Sean Christopherson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yd8chbAyJA1XB9bY@google.com \
--to=seanjc@google.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).