From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24B1AC4332F for ; Wed, 5 Jan 2022 22:29:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244977AbiAEW3K (ORCPT ); Wed, 5 Jan 2022 17:29:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39026 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244951AbiAEW3J (ORCPT ); Wed, 5 Jan 2022 17:29:09 -0500 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8FD78C061245 for ; Wed, 5 Jan 2022 14:29:09 -0800 (PST) Received: by mail-pj1-x1036.google.com with SMTP id c9-20020a17090a1d0900b001b2b54bd6c5so5860781pjd.1 for ; Wed, 05 Jan 2022 14:29:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=NlNJ4grmTdeP8Ezi+MHLWLR1H1WOrSKO/roOqPIpLbo=; b=lcWVbw4ShlPDOZFedTW9LKOrUtdb0j3Ok8QwjZL8FBH5aeSmphdXAviZUApWVabJb8 7mZiOI+HYWoiuw9OnP1dEWf+3SAc2EemATQSiH+geyoR3m00KucUcyfLLH428z3KMu3f Sd3raTZPd0glAqzErWQNsYb8C+R27GgqE7Mlgz8JyXPcJAuv3jBIQfynG4tq1UvnI6/M DU+wvedrGddOUpODqItCFlOOjxzWK+KPv0jGTsIbfAkLwzMsB40eO9cP0zYyLedPWVT/ UnVR1B8xFbscWQ2l1T8EWcI64u/gQWqHV0IFWaka7AmfIOaGTuG/8kmljTWb8b3hyu1x bnfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=NlNJ4grmTdeP8Ezi+MHLWLR1H1WOrSKO/roOqPIpLbo=; b=swVWz09vQjZWogJz4l0f+1OGRYtxdaDo7bf0lKuPaCV96/60Zjcb8w6/iCdXhpYz6y nrJL3C+7rcMFEfZaJcBJgcgJ7mDgedIg3d+MWP63lv2UH+isDgHlfa+5W6dJIhUo3+5e 64NH+kjQBXqt5KmeIu34OgY5ZS6ijs/oEcNY9klVRogJpTWofZ/TiWmWNtIDC3zCmA04 TPk7HNssAcUvkHz25LSS6vbYZW1s6RW9A7Yw7xBGv0qVEpYq9V7xfJfKnvXEtniR6zuU wdCot2A0mQXdp52sWdpMMdBFxWoYMVguX1r0fhxFPn1FWSB9u1thrs4s1b8RMNrRMBeU AJYw== X-Gm-Message-State: AOAM531KA6BXJjuf6nhK1gl8aChI3qI+W+KZk5p0r4Y/w0QuYL3pgzXB aSAA5tlhtqLFFYrVMdctMIicbQ== X-Google-Smtp-Source: ABdhPJw/hS0IxkmtNQWaTfp7MjckeyXJKDDA6HAM1Mtx+suUSTVQ4BsX6dhq/PytaoZhbdgDvhwzKA== X-Received: by 2002:a17:90b:4a86:: with SMTP id lp6mr6662981pjb.57.1641421749028; Wed, 05 Jan 2022 14:29:09 -0800 (PST) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id p6sm52463pgl.16.2022.01.05.14.29.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jan 2022 14:29:08 -0800 (PST) Date: Wed, 5 Jan 2022 22:29:05 +0000 From: Sean Christopherson To: Yang Zhong Cc: x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, pbonzini@redhat.com, corbet@lwn.net, shuah@kernel.org, jun.nakajima@intel.com, kevin.tian@intel.com, jing2.liu@linux.intel.com, jing2.liu@intel.com, guang.zeng@intel.com, wei.w.wang@intel.com Subject: Re: [PATCH v5 16/21] kvm: x86: Add CPUID support for Intel AMX Message-ID: References: <20220105123532.12586-1-yang.zhong@intel.com> <20220105123532.12586-17-yang.zhong@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220105123532.12586-17-yang.zhong@intel.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, Jan 05, 2022, Yang Zhong wrote: > From: Jing Liu > > Extend CPUID emulation to support XFD, AMX_TILE, AMX_INT8 and > AMX_BF16. Adding those bits into kvm_cpu_caps finally activates all > previous logics in this series. > > Hide XFD on 32bit host kernels. Otherwise it leads to a weird situation > where KVM tells userspace to migrate MSR_IA32_XFD and then rejects > attempts to read/write the MSR. > > Signed-off-by: Jing Liu > Signed-off-by: Sean Christopherson No need for my SoB, I provided a very tiny snippet of code review. > Signed-off-by: Yang Zhong > ---