From: Sean Christopherson <seanjc@google.com>
To: Shivam Kumar <shivam.kumar1@nutanix.com>
Cc: pbonzini@redhat.com, kvm@vger.kernel.org, agraf@csgraf.de,
Shaju Abraham <shaju.abraham@nutanix.com>,
Manish Mishra <manish.mishra@nutanix.com>,
Anurag Madnawat <anurag.madnawat@nutanix.com>
Subject: Re: [PATCH v2 1/1] KVM: Implement dirty quota-based throttling of vcpus
Date: Wed, 26 Jan 2022 21:04:10 +0000 [thread overview]
Message-ID: <YfG3Sqng7pn+SnG/@google.com> (raw)
In-Reply-To: <d610ce6d-3753-405b-80c7-b6c5f261fce2@nutanix.com>
On Mon, Jan 24, 2022, Shivam Kumar wrote:
>
> On 10/01/22 11:38 pm, Sean Christopherson wrote:
> > On Mon, Dec 20, 2021, Shivam Kumar wrote:
> > For other architectures, unless the arch maintainers explicitly don't want to
> > support this, I would prefer we enable at least arm64 right away to prevent this
> > from becoming a de facto x86-only feature. s390 also appears to be easy to support.
> > I almost suggested moving the check to generic code, but then I looked at MIPS
> > and PPC and lost all hope :-/
> >
> > > + vcpu->run->exit_reason = KVM_EXIT_DIRTY_QUOTA_FULL;
> > >
> > >
> > > --
> > >
> I am not able to test this on arm64 and s390 as I don't have access to arm64
> and s390 hardware. Looking forward to your suggestions. Thank you!
Posting patches for other architectures that are compile-tested only is ok, just
be sure to note as much in the cover letter (or ignored part of the patch if it's
a single patchy). I don't think there's anyone that has access to _all_ KVM
ports, though there might be someone that has x86, arm64, and s390. In other words,
inability to test other architectures is very normal. The arm64 and s390 maintainers
will need to ack the change in any case.
next prev parent reply other threads:[~2022-01-26 21:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-20 5:57 [PATCH v2 0/1] KVM: Dirty quota-based throttling Shivam Kumar
2021-12-20 5:57 ` [PATCH v2 1/1] KVM: Implement dirty quota-based throttling of vcpus Shivam Kumar
2022-01-10 18:08 ` Sean Christopherson
[not found] ` <eca3faed-5f2c-6217-fb2c-298855510265@nutanix.com>
2022-01-11 16:59 ` Sean Christopherson
2022-01-23 18:58 ` Shivam Kumar
2022-01-26 21:04 ` Sean Christopherson [this message]
2022-01-03 8:46 ` [PATCH v2 0/1] KVM: Dirty quota-based throttling Shivam Kumar
2022-01-04 17:01 ` Sean Christopherson
2022-01-05 15:39 ` Shivam Kumar
2022-03-08 14:59 ` Paolo Bonzini
2022-03-08 15:53 ` Sean Christopherson
2022-03-08 18:22 ` Shivam Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YfG3Sqng7pn+SnG/@google.com \
--to=seanjc@google.com \
--cc=agraf@csgraf.de \
--cc=anurag.madnawat@nutanix.com \
--cc=kvm@vger.kernel.org \
--cc=manish.mishra@nutanix.com \
--cc=pbonzini@redhat.com \
--cc=shaju.abraham@nutanix.com \
--cc=shivam.kumar1@nutanix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).