From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66507C433EF for ; Fri, 18 Feb 2022 15:52:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237227AbiBRPw1 (ORCPT ); Fri, 18 Feb 2022 10:52:27 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:40970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233041AbiBRPwZ (ORCPT ); Fri, 18 Feb 2022 10:52:25 -0500 Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A84236314 for ; Fri, 18 Feb 2022 07:52:09 -0800 (PST) Received: by mail-pg1-x533.google.com with SMTP id w37so1840634pga.7 for ; Fri, 18 Feb 2022 07:52:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=6TSRYisI11TAgCQBrFqDAThitIb+GPMmpzMU4WS3apc=; b=NdyomdpsrJELKx7oL9mgw4SmSILqmSgqrkTyigEVnxocv/MaFbeTc02oW/6+Sy7XO1 RLmhvlmBewehRotjQLwpLRiDeeV7xp/vtOQGLZj3S+/ngCoIQS3Wvoor+75nZ6t0hjH/ 4WY6yxQ6aTjR0shAZ1py6WqiIQEpxLEtl6y2DDXR1etz+Z30Ur5ZlVaXBqINnl7dWXUZ Fbcuk9sBSMANatmLJfkImQ1SCrQUXedbF4+mpWo9VeS4ah+Yhmh0BAvs5WwvDm3n8rus AmF9a1C70u26CKXoaOm53+u+ndiFTF49myq7rhT97pPrjHeYDE95S5o/tvfFCcMNwMd5 GqWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=6TSRYisI11TAgCQBrFqDAThitIb+GPMmpzMU4WS3apc=; b=ut91HBLiusaKFRmh4gKH3L8RlRzmkrtQqguzupkX4XtmNskMstRsPvPxscU1PaPIOo SRjCvJfcOoEfNaAWjNlmNAdRV1RCsmr+yOMNwyAjUcm/ldJQlnmmrfBzNEhTOtYLYITM aNNdDylfIp40hoSC+phA/0yu0uNv9qFy2pChIcq8hrn4soJpNgoAVkg6RmwZxX4Veftl Uxjr11KZA0hwfnfvLhBojEVepqe2KC6qhy424j/sRxO055haG43N5OgGj2jNXrwLZZ81 uz9D+6nx/fPItw2enAi9Bj+h7BkuwgLhj69eEA73vkewvlAc1YeFXoO3qZwZkw10/2vd uNYg== X-Gm-Message-State: AOAM531iVooA+ZFX00L2UVD612/SlLYKs1N6lE3+NPyt7rUAaN9Ywi49 Xj8eKQeI/Xy2wpMWANcGIYghlDS20/NV0A== X-Google-Smtp-Source: ABdhPJzQvFTK1YdORlSGsV0PeaQIkdrquMN8iJ7oendQPTrI9bCRs0tpiXuV/2zxQMCbsmNcaenNBA== X-Received: by 2002:a63:6a85:0:b0:35d:8508:9208 with SMTP id f127-20020a636a85000000b0035d85089208mr6817828pgc.17.1645199528759; Fri, 18 Feb 2022 07:52:08 -0800 (PST) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id h20sm3321728pfq.162.2022.02.18.07.52.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Feb 2022 07:52:08 -0800 (PST) Date: Fri, 18 Feb 2022 15:52:04 +0000 From: Sean Christopherson To: Paolo Bonzini Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH v3 3/6] KVM: x86: remove KVM_X86_OP_NULL and mark optional kvm_x86_ops Message-ID: References: <20220217180831.288210-1-pbonzini@redhat.com> <20220217180831.288210-4-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220217180831.288210-4-pbonzini@redhat.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, Feb 17, 2022, Paolo Bonzini wrote: > The original use of KVM_X86_OP_NULL, which was to mark calls > that do not follow a specific naming convention, is not in use > anymore. Instead, let's mark calls that are optional because > they are always invoked within conditionals or with static_call_cond. > Those that are _not_, i.e. those that are defined with KVM_X86_OP, > must be defined by both vendor modules or some kind of NULL pointer > dereference is bound to happen at runtime. > > Signed-off-by: Paolo Bonzini > --- Reviewed-by: Sean Christopherson