Re: [PATCH v2 7/7] KVM: VMX: Use local pointer to vcpu_vmx in vmx_vcpu_after_set_cpuid()

Paolo Bonzini
2022-02-07T16:47:36Z

On 2/4/22 21:47, Oliver Upton wrote:
> There is a local that contains a pointer to vcpu_vmx already. Just use
> that instead to get at the structure directly instead of doing pointer
> arithmetic.
>
> No functional change intended.
>
> Signed-off-by: Oliver Upton <oupton@google.com>
> ---
> arch/x86/kvm/vmx/vmx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
> index 60b1b76782e1..11b6332769c5 100644
> --- a/arch/x86/kvm/vmx/vmx.c
> +++ b/arch/x86/kvm/vmx/vmx.c
> @@ -7338,11 +7338,11 @@ static void vmx_vcpu_after_set_cpuid(struct kvm_vcpu *vcpu)
> vmx_secondary_exec_control(vmx));
>
> if (nested_vmx_allowed(vcpu))
> - to_vmx(vcpu)->msr_ia32_feature_control_valid_bits |=
> + vmx->msr_ia32_feature_control_valid_bits |=
> FEAT_CTL_VMX_ENABLED_INSIDE_SMX |
> FEAT_CTL_VMX_ENABLED_OUTSIDE_SMX;
> else
> - to_vmx(vcpu)->msr_ia32_feature_control_valid_bits &=
> + vmx->msr_ia32_feature_control_valid_bits &=
> ~(FEAT_CTL_VMX_ENABLED_INSIDE_SMX |
> FEAT_CTL_VMX_ENABLED_OUTSIDE_SMX);
>

Queued, thanks.

Paolo