From: Sean Christopherson <seanjc@google.com>
To: Manali Shukla <manali.shukla@amd.com>
Cc: pbonzini@redhat.com, kvm@vger.kernel.org, aaronlewis@google.com
Subject: Re: [kvm-unit-tests PATCH 1/3] x86: Add routines to set/clear PT_USER_MASK for all pages
Date: Mon, 14 Feb 2022 19:30:09 +0000 [thread overview]
Message-ID: <YgqtwRwYbJD5f9nA@google.com> (raw)
In-Reply-To: <20220207051202.577951-2-manali.shukla@amd.com>
On Mon, Feb 07, 2022, Manali Shukla wrote:
> Add following 2 routines :
> 1) set_user_mask_all() - set PT_USER_MASK for all the levels of page tables
> 2) clear_user_mask_all - clear PT_USER_MASK for all the levels of page tables
>
> commit 916635a813e975600335c6c47250881b7a328971
> (nSVM: Add test for NPT reserved bit and #NPF error code behavior)
> clears PT_USER_MASK for all svm testcases. Any tests that requires
> usermode access will fail after this commit.
Gah, I took the easy route and it burned us. I would rather we start breaking up
the nSVM and nVMX monoliths, e.g. add a separate NPT test and clear the USER flag
only in that test, not the "common" nSVM test.
If we don't do that, this should really use walk_pte() instead of adding yet
another PTE walker.
next prev parent reply other threads:[~2022-02-14 21:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-07 5:11 [kvm-unit-tests PATCH 0/3] nSVM: Add testing for routing L2 exceptions Manali Shukla
2022-02-07 5:12 ` [kvm-unit-tests PATCH 1/3] x86: Add routines to set/clear PT_USER_MASK for all pages Manali Shukla
2022-02-14 19:30 ` Sean Christopherson [this message]
2022-02-17 3:55 ` Shukla, Manali
2022-02-17 14:34 ` Aaron Lewis
2022-02-20 4:42 ` Shukla, Manali
2022-02-17 15:20 ` Sean Christopherson
2022-02-20 5:35 ` Shukla, Manali
2022-02-07 5:12 ` [kvm-unit-tests PATCH 2/3] x86: Make exception_mnemonic() visible to the tests Manali Shukla
2022-02-07 5:12 ` [kvm-unit-tests PATCH 3/3] x86: nSVM: Add an exception test framework and tests Manali Shukla
2022-02-14 20:20 ` Aaron Lewis
2022-02-17 3:26 ` Shukla, Manali
2022-02-17 14:46 ` Aaron Lewis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YgqtwRwYbJD5f9nA@google.com \
--to=seanjc@google.com \
--cc=aaronlewis@google.com \
--cc=kvm@vger.kernel.org \
--cc=manali.shukla@amd.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox