From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Christian Borntraeger <borntraeger@linux.ibm.com>,
kvm@vger.kernel.org, linux-s390@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Janosch Frank <frankja@linux.ibm.com>,
Claudio Imbrenda <imbrenda@linux.ibm.com>,
David Hildenbrand <david@redhat.com>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>
Subject: Re: [PATCH v1 1/1] KVM: s390: Don't cast parameter in bit operations
Date: Wed, 2 Mar 2022 17:45:20 +0200 [thread overview]
Message-ID: <Yh+REPSQd1zX8KlQ@smile.fi.intel.com> (raw)
In-Reply-To: <20220223164420.45344-1-andriy.shevchenko@linux.intel.com>
On Wed, Feb 23, 2022 at 06:44:20PM +0200, Andy Shevchenko wrote:
> While in this particular case it would not be a (critical) issue,
> the pattern itself is bad and error prone in case somebody blindly
> copies to their code.
>
> Don't cast parameter to unsigned long pointer in the bit operations.
> Instead copy to a local variable on stack of a proper type and use.
After looking into other similar cases I may conclude they
- need to be fixed
- out of scope of this change
Hence, can this fix be applied?
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2022-03-02 15:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-23 16:44 [PATCH v1 1/1] KVM: s390: Don't cast parameter in bit operations Andy Shevchenko
2022-02-24 11:36 ` Claudio Imbrenda
2022-02-24 12:10 ` Michael Mueller
2022-03-02 15:44 ` Andy Shevchenko
2022-03-02 17:18 ` Yury Norov
2022-03-02 17:31 ` Andy Shevchenko
2022-03-02 18:43 ` Yury Norov
2022-03-03 10:19 ` Andy Shevchenko
2022-02-24 19:51 ` Andy Shevchenko
2022-02-24 23:15 ` David Laight
2022-03-02 15:45 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yh+REPSQd1zX8KlQ@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox