From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D76DDC433EF for ; Wed, 2 Mar 2022 17:55:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244211AbiCBR4m (ORCPT ); Wed, 2 Mar 2022 12:56:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233784AbiCBR4l (ORCPT ); Wed, 2 Mar 2022 12:56:41 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A7775D0496 for ; Wed, 2 Mar 2022 09:55:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1646243756; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o+nBkQbgw8PwPPv2SFeP3n6nYROMRVLwtSKO9jqS6Kk=; b=avU9iA0y223BFDoPpQqOuRlKYPAxjX/ugAK5kOQ9L1WjMVWt4W8XXRRkrQOO4mSciJgpIn c+OYjwD6KxdZG2Z4tW3eGVlFFOMzFxGYzsDsQ6LUOmnLsbYBM9X/xkAKL8bQMXolEuOfoh yZmngzfRVcIy7Et4i1mq+9a1ifRHkWc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-37-Vbhj1pRiOdKGIW1mPP7Ang-1; Wed, 02 Mar 2022 12:55:53 -0500 X-MC-Unique: Vbhj1pRiOdKGIW1mPP7Ang-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 246CE824FA9; Wed, 2 Mar 2022 17:55:51 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.166]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 41F688659D; Wed, 2 Mar 2022 17:55:45 +0000 (UTC) Date: Wed, 2 Mar 2022 17:55:42 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: Sergio Lopez , Fam Zheng , Elena Ufimtseva , kvm@vger.kernel.org, "Michael S. Tsirkin" , qemu-devel@nongnu.org, Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Jagannathan Raman , Matthew Rosato , qemu-block@nongnu.org, David Hildenbrand , Halil Pasic , Thomas Huth , Christian Borntraeger , vgoyal@redhat.com, Eric Farman , Richard Henderson , qemu-s390x@nongnu.org, Stefan Hajnoczi , Kevin Wolf , John G Johnson , Cornelia Huck , Alex Williamson , Hanna Reitz , Paolo Bonzini Subject: Re: [PATCH 2/2] Allow building vhost-user in BSD Message-ID: Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20220302113644.43717-1-slp@redhat.com> <20220302113644.43717-3-slp@redhat.com> <66b68bcc-8d7e-a5f7-5e6c-b2d20c26ab01@redhat.com> <8dfc9854-4d59-0759-88d0-d502ae7c552f@gmail.com> <20220302173009.26auqvy4t4rx74td@mhamilton> <85ed0856-308a-7774-a751-b20588f3d9cd@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <85ed0856-308a-7774-a751-b20588f3d9cd@gmail.com> User-Agent: Mutt/2.1.5 (2021-12-30) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, Mar 02, 2022 at 06:38:07PM +0100, Philippe Mathieu-Daudé wrote: > On 2/3/22 18:31, Sergio Lopez wrote: > > On Wed, Mar 02, 2022 at 06:18:59PM +0100, Philippe Mathieu-Daudé wrote: > > > On 2/3/22 18:10, Paolo Bonzini wrote: > > > > On 3/2/22 12:36, Sergio Lopez wrote: > > > > > With the possibility of using pipefd as a replacement on operating > > > > > systems that doesn't support eventfd, vhost-user can also work on BSD > > > > > systems. > > > > > > > > > > This change allows enabling vhost-user on BSD platforms too and > > > > > makes libvhost_user (which still depends on eventfd) a linux-only > > > > > feature. > > > > > > > > > > Signed-off-by: Sergio Lopez > > > > > > > > I would just check for !windows. > > > > > > What about Darwin / Haiku / Illumnos? > > > > It should work on every system providing pipe() or pipe2(), so I guess > > Paolo's right, every platform except Windows. FWIW, I already tested > > it with Darwin. > > Wow, nice. > > So maybe simply check for pipe/pipe2 rather than !windows? NB that would make the check more fragile. We already use pipe/pipe2 without checking for it, because its usage is confined to oslib-posix.c and we know all POSIX OS have it. There is no impl at all of qemu_pipe in oslib-win.c and the declaration is masked out too in the header file. Thus if we check for pipe2 and windows did ever implement it, then we would actually break the windows build due to qemu_pipe not existing. IOW, checking !windows matches our logic for picking oslib-posix.c in builds and so is better than checking for pipe directly. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|