From: Sean Christopherson <seanjc@google.com>
To: Like Xu <like.xu.linux@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Jim Mattson <jmattson@google.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Joerg Roedel <joro@8bytes.org>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: x86: Fix function address when kvm_x86_ops.func is NULL
Date: Tue, 22 Feb 2022 15:25:16 +0000 [thread overview]
Message-ID: <YhUAXKkGjO/Yjz8G@google.com> (raw)
In-Reply-To: <fb9e8765-33d8-5696-37bc-98e33c93f0c2@gmail.com>
On Tue, Feb 22, 2022, Like Xu wrote:
> On 22/2/2022 4:33 pm, Paolo Bonzini wrote:
> > On 2/22/22 07:25, Like Xu wrote:
> > > From: Like Xu <likexu@tencent.com>
> > >
> > > Fix the function address for __static_call_return0() which is used by
> > > static_call_update() when a func in struct kvm_x86_ops is NULL.
> > >
> > > Fixes: 5be2226f417d ("KVM: x86: allow defining return-0 static calls")
> > > Signed-off-by: Like Xu <likexu@tencent.com>
> >
> > Sorry for the stupid question, but what breaks?
>
> Although they are numerically the same, I suppose we should use the
> & operator here, as in the other cases where __static_call_return0 is used.
Meh, IMO all the other instances are weird for adding the "&".
prev parent reply other threads:[~2022-02-22 15:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-22 6:25 [PATCH] KVM: x86: Fix function address when kvm_x86_ops.func is NULL Like Xu
2022-02-22 8:33 ` Paolo Bonzini
2022-02-22 8:54 ` Like Xu
2022-02-22 15:25 ` Sean Christopherson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhUAXKkGjO/Yjz8G@google.com \
--to=seanjc@google.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=like.xu.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox