From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CF60C433EF for ; Tue, 22 Feb 2022 15:25:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233468AbiBVPZs (ORCPT ); Tue, 22 Feb 2022 10:25:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40428 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233300AbiBVPZq (ORCPT ); Tue, 22 Feb 2022 10:25:46 -0500 Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [IPv6:2607:f8b0:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1FEC7162036 for ; Tue, 22 Feb 2022 07:25:21 -0800 (PST) Received: by mail-pg1-x529.google.com with SMTP id 12so13741065pgd.0 for ; Tue, 22 Feb 2022 07:25:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=JOVsUFfKVdevn4xo8tl2n5gZT4eizbbSPVY0rmb9bKM=; b=hkCJ+If856zbN40skCffOWE5ppC+hZSvhR64QkWhgmk15mi10rMYEdpZKZwIf5cuJ+ MieJE7z+kiDP3QvwQ5+L1uftB6EnkiXgSc6Gy7JfZjYp5EH9JakMONqr+vrU2+L35Mfd T0t946GmC1gpd70jvmwt5s3Yk8dEwX9K3AHRLgvc086Y4EJaR2pHtaUZC0DxugYGNBni EwsyrZ5w55w02H8LA4FIP40u5XmhXHDyMtkNHpkAsnWBN8D7ciOyO0U4PQVe8eKqcm+s UDk9qlPc0wrmYACdpvu6TcHWnzVQJNXNentJLVuiqNuFSZP0Cu3MIibAfXciY23o8hj1 2gug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=JOVsUFfKVdevn4xo8tl2n5gZT4eizbbSPVY0rmb9bKM=; b=Eckr5YYMq6OecswJ0cGCs93z3iJrlj0wo0foTCXTmomPH8LjHRYimWSXDh9Q8WQ9ss 8rXr0sFX2Gf7nLpdh1O02wnUp17MQ5ulL7BUcH51yvvunACas4sI53NEQ+7Q98Y3J2YS DLLDVnHE76qDu3I6CBifP2e8rikqq9oblINnkmNnn4fUa69DW/zxLxHXL1xkSxb0M8Kz mXs1hsYf004pMfTFQQz76YKI7vdwI0/QNjoYP2uuxaLCRyFMWClYc1ci/HYeFjzyU8zz hqNxZcH6f+3nJvsJNcvq/RBVykwkNnIxe6BLK3hjkAfT1PT3VDj90HY/J2NDrVZWKHQL nq/w== X-Gm-Message-State: AOAM532WTLyIfoVtSXgIHsyr8dJcfM62AbZaNEJkxzfQXD+W9YICtD6X b2FQVTlL9qCNuk8TD3WVXfZbWQ== X-Google-Smtp-Source: ABdhPJzzL85VCR+MvGAAUkiNedsSi1qI0C6f+LwJD7Gf2CaiPgeGKiP+EybUjXrjl/zxArP1USdK6g== X-Received: by 2002:a05:6a00:1c46:b0:4e1:82cb:e39c with SMTP id s6-20020a056a001c4600b004e182cbe39cmr25608230pfw.18.1645543520485; Tue, 22 Feb 2022 07:25:20 -0800 (PST) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id h27sm21100567pgb.20.2022.02.22.07.25.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Feb 2022 07:25:19 -0800 (PST) Date: Tue, 22 Feb 2022 15:25:16 +0000 From: Sean Christopherson To: Like Xu Cc: Paolo Bonzini , Jim Mattson , Vitaly Kuznetsov , Wanpeng Li , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] KVM: x86: Fix function address when kvm_x86_ops.func is NULL Message-ID: References: <20220222062510.48592-1-likexu@tencent.com> <01ba8559-b6f9-cc75-2080-7308a04ce262@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, Feb 22, 2022, Like Xu wrote: > On 22/2/2022 4:33 pm, Paolo Bonzini wrote: > > On 2/22/22 07:25, Like Xu wrote: > > > From: Like Xu > > > > > > Fix the function address for __static_call_return0() which is used by > > > static_call_update() when a func in struct kvm_x86_ops is NULL. > > > > > > Fixes: 5be2226f417d ("KVM: x86: allow defining return-0 static calls") > > > Signed-off-by: Like Xu > > > > Sorry for the stupid question, but what breaks? > > Although they are numerically the same, I suppose we should use the > & operator here, as in the other cases where __static_call_return0 is used. Meh, IMO all the other instances are weird for adding the "&".