Re: [EXTERNAL] [PATCH v2] KVM: Don't actually set a request when evicting vCPUs for GFN cache invd

David Woodhouse
2022-02-24T10:14:38Z

[-- Attachment #1: Type: text/plain, Size: 586 bytes --]

On Wed, 2022-02-23 at 16:53 +0000, Sean Christopherson wrote:
> + /*
> + * Request that don't require vCPU action should never be logged in
> + * vcpu->requests. The vCPU won't clear the request, so it will stay
> + * logged indefinitely and prevent the vCPU from entering the guest.
> + */
> + BUILD_BUG_ON(!__builtin_constant_p(req) ||
> + (req & KVM_REQUEST_NO_ACTION));

Should KVM_REQ_UNHALT be one of these? Might have saved me a number of
hours of debugging the SCHEDOP_poll patch I'm about to repost...

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5965 bytes --]