Re: [PATCH 1/1] vhost: Protect the virtqueue from being cleared whilst still in use

Lee Jones
2022-03-04T15:22:54Z

On Fri, 04 Mar 2022, Michael S. Tsirkin wrote:

> On Wed, Mar 02, 2022 at 07:54:21AM +0000, Lee Jones wrote:
> > vhost_vsock_handle_tx_kick() already holds the mutex during its call
> > to vhost_get_vq_desc(). All we have to do is take the same lock
> > during virtqueue clean-up and we mitigate the reported issues.
> >
> > Link: https://syzkaller.appspot.com/bug?extid=279432d30d825e63ba00
> >
> > Cc: <stable@vger.kernel.org>
> > Reported-by: syzbot+adc3cb32385586bec859@syzkaller.appspotmail.com
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
>
> So combine with the warning patch and update description with
> the comment I posted, explaining it's more a just in case thing.

Will do. Plan is to submit this on Monday.

--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog