From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08DEAC433EF for ; Thu, 3 Mar 2022 16:59:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235212AbiCCRA1 (ORCPT ); Thu, 3 Mar 2022 12:00:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230252AbiCCRA0 (ORCPT ); Thu, 3 Mar 2022 12:00:26 -0500 Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F74E16203A for ; Thu, 3 Mar 2022 08:59:40 -0800 (PST) Received: by mail-pj1-x1033.google.com with SMTP id m11-20020a17090a7f8b00b001beef6143a8so5388861pjl.4 for ; Thu, 03 Mar 2022 08:59:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=TRe594s70/BSgqAig7s+8kVsNXAhB41CkpW4XEV91Hg=; b=Sw0dfYxFJ4mEKPvVublWYLsl673lFfJ18wDifxKlKiovIH089C/9DXqx76iw+U9Wy1 c1QZEs/MqMiWOaevM2WlLHTh9kxnCfRnHseHHrArIGj5zCh7NuIA5+mLEPKfM1HDYAjj KeX4REFSgSXsCkIJugPgRW8jOLuV4i4C5vJLDAdw+ygAHwbKFm3tIwOGzm9ZIJ3zLAbi iRov0EnBkeoxOiMZf/W1aSyhlXQPw1zq+pnjcpFm4RjNTAeMRtd3mAomXCp+mhkAANRY SMQDUSV9wuO4oWfxGQwK/UkFWNnnRFDeQSayvqvTNKh9rNu3RdkAwy+P1OtFzm6n7reI wOnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=TRe594s70/BSgqAig7s+8kVsNXAhB41CkpW4XEV91Hg=; b=AUQhFGGVj8QLOQb+FzoTa44FVjPU24pu+gKxi+4CPY3nXrI7Z8gB2xu367N3/4D782 ngB4HpDmzvf8hoCrNRarw5+WJbgQTYOg9hoa6V3SFEX/JpvNlBNVKFcBCI3WXs14H50H 2bGF4dhPAtEoGZQxUzPZ3NUXFJZF4e3AQH8CHYbg922JnTh+qRR4x1vlbZig50BGi84Y viHuwDgRbBIfwT9fzT/q5xTVdWc3pesvbfJCaL9c9pqEyHCmYFHw503orF5OdcMJ6hDh IAnrdTWXdvyG9IlFz8/A9nr1cn/wEcft8fts2m3U/tdbyOszEgzp5EGtH9KlklnPosqd M+yw== X-Gm-Message-State: AOAM531XX4cwpedkS2vhlcSJp7duPkyTWly90x6+dv94MfOkfp8ubTBe +ftgHvzYXKZpdZajmwM+r3ef7LpYw+bhSw== X-Google-Smtp-Source: ABdhPJxb4kj47xxaByYvUO4XtKKnHahIGOZu3XEgeG5BAzJeSsGKxMgaQOn+rxpNIox3oVhLlWIOmw== X-Received: by 2002:a17:903:244d:b0:150:18f3:8e98 with SMTP id l13-20020a170903244d00b0015018f38e98mr37058822pls.28.1646326779923; Thu, 03 Mar 2022 08:59:39 -0800 (PST) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id a19-20020a17090ad81300b001bc447c2c91sm8558375pjv.31.2022.03.03.08.59.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Mar 2022 08:59:39 -0800 (PST) Date: Thu, 3 Mar 2022 16:59:35 +0000 From: Sean Christopherson To: Peter Gonda Cc: kvm list , Paolo Bonzini , LKML Subject: Re: [PATCH] KVM: SVM: Fix missing kvm_cache_regs.h include in svm.h Message-ID: References: <20220303160442.1815411-1-pgonda@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, Mar 03, 2022, Peter Gonda wrote: > On Thu, Mar 3, 2022 at 9:26 AM Sean Christopherson wrote: > > Ha, we've already got a lovely workaround for exactly this problem. This patch > > should drop the include from svm_onhyperv.c, there's nothing in that file that > > needs kvm_cache_regs.h (I verified by deleting use of is_guest_mode()), it's > > included purely because of this bug in svm.h. > > Ah good catch. I assume I should add kvm_cache_regs.h to > arch/x86/kvm/svm/nested.c too since it uses is_guest_mode(). Nah, picking it up from svm.h (and several other headers) is ok. If we required every compilation unit to _directly_ include every header, we'd probably double the size of the kernel source :-)