From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46A01C433EF for ; Tue, 8 Mar 2022 10:45:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345958AbiCHKqr (ORCPT ); Tue, 8 Mar 2022 05:46:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345929AbiCHKqq (ORCPT ); Tue, 8 Mar 2022 05:46:46 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 6CF9D42EF1 for ; Tue, 8 Mar 2022 02:45:50 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3CD5F1FB; Tue, 8 Mar 2022 02:45:50 -0800 (PST) Received: from monolith.localdoman (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E71D23FA45; Tue, 8 Mar 2022 02:45:48 -0800 (PST) Date: Tue, 8 Mar 2022 10:46:10 +0000 From: Alexandru Elisei To: Sebastian Ene Cc: kvm@vger.kernel.org, qperret@google.com, maz@kernel.org, kvmarm@lists.cs.columbia.edu, will@kernel.org, julien.thierry.kdev@gmail.com Subject: Re: [PATCH kvmtool v8 3/3] Add --no-pvtime command line argument Message-ID: References: <20220307144243.2039409-1-sebastianene@google.com> <20220307144243.2039409-4-sebastianene@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220307144243.2039409-4-sebastianene@google.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Hi, Looks good to me: Reviewed-by: Alexandru Elisei Thanks, Alex On Mon, Mar 07, 2022 at 02:42:44PM +0000, Sebastian Ene wrote: > The command line argument disables the stolen time functionality when is > specified. > > Signed-off-by: Sebastian Ene > --- > builtin-run.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/builtin-run.c b/builtin-run.c > index 9a1a0c1..7c8be9d 100644 > --- a/builtin-run.c > +++ b/builtin-run.c > @@ -128,6 +128,8 @@ void kvm_run_set_wrapper_sandbox(void) > " rootfs"), \ > OPT_STRING('\0', "hugetlbfs", &(cfg)->hugetlbfs_path, "path", \ > "Hugetlbfs path"), \ > + OPT_BOOLEAN('\0', "no-pvtime", &(cfg)->no_pvtime, "Disable" \ > + " stolen time"), \ > \ > OPT_GROUP("Kernel options:"), \ > OPT_STRING('k', "kernel", &(cfg)->kernel_filename, "kernel", \ > -- > 2.35.1.616.g0bdcbb4464-goog >