From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF934C433FE for ; Tue, 8 Mar 2022 19:52:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350096AbiCHTxy (ORCPT ); Tue, 8 Mar 2022 14:53:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344546AbiCHTxv (ORCPT ); Tue, 8 Mar 2022 14:53:51 -0500 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B341A2F00B for ; Tue, 8 Mar 2022 11:52:54 -0800 (PST) Received: by mail-pl1-x62d.google.com with SMTP id z3so49420plg.8 for ; Tue, 08 Mar 2022 11:52:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+GJxf+d39qt6iXcqaU88WSLmjEEiwXwQFcgKUX2udck=; b=K2ZJ5oM80IEwsivF+mIyCOMFnUjkdTZeUhvZaPuCCaAznX+6UEWVgqDVEPO8Uc9UFr bqE+y76VujAHCxuU0xefJgUX7fGaZXGaLQzuRSsPxyyubp774ugflszdjRYjY1eDjTQ5 jf7LYUxn5m+msYgbX9xMRJ6zBp4TejcIx80lx5JQMZiyxh4oWXfD9L3eP5Y0u2DRQT8o rOw00CtxOuu3qLe8upbYseBwZmci4ObK25HCjW/TWnh49hN2JONa/+AnPLWAXjS2yjHg CJRGOD6lb9PCiTqynhOgnVd3LUEtPjmHtnOXGvGaUriRjKBWI8+tAWavmw3csV+/TX5b idgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+GJxf+d39qt6iXcqaU88WSLmjEEiwXwQFcgKUX2udck=; b=mNyLNtSxCds/mrKv5reqGwug/aeLyDrMHKJGI21LGnJKTo20O511Ms1V+bdkkyzBBP vIl0cvdbAYIdhmfbOXtOeme7MedJhm9cIoK3sFEQWfIrL/lP9ldMMZBlfUqvAJiLafAM TwvSnMv4/ZJkG8ofK8wThopBnTZM4Baanjk/0wyIdK5p75YDwZhDvYbnWDGz5DNmp0iL AMJiC5/ua7Bi8o3zIEKDMWGLzMU+yNA/3/dGq5wsmsUxzT+xrPnaF2whJxBCtlgTvj/B +L5Zi6t3QZHkS6n1htcvCrjtpuI/G5Qc3WqLW8qa1+wWKHAqxawIwuPTUfYU8Q3BA+4j ZZBQ== X-Gm-Message-State: AOAM530NqYkgoUJaaDkPMAUZCt3AyJ0WF29Q7K8+k3l8XVhpt0YvB49L RR1LfVExJvkrsj5m8cmbsPxQ6Q== X-Google-Smtp-Source: ABdhPJxtm3yXSWCs360VhpTT9/lZjt5ym3fYUaEYjIvc+92rHKX8gYlg0fNfcE03LyvJk1sRgmaXJQ== X-Received: by 2002:a17:902:c94a:b0:151:8e65:c715 with SMTP id i10-20020a170902c94a00b001518e65c715mr19217057pla.169.1646769174088; Tue, 08 Mar 2022 11:52:54 -0800 (PST) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id j14-20020a056a00174e00b004f66ce6367bsm22475439pfc.147.2022.03.08.11.52.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Mar 2022 11:52:53 -0800 (PST) Date: Tue, 8 Mar 2022 19:52:50 +0000 From: Sean Christopherson To: Paolo Bonzini Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, dmatlack@google.com Subject: Re: [PATCH v2 23/25] KVM: x86/mmu: replace direct_map with root_role.direct Message-ID: References: <20220221162243.683208-1-pbonzini@redhat.com> <20220221162243.683208-24-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220221162243.683208-24-pbonzini@redhat.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, Feb 21, 2022, Paolo Bonzini wrote: > direct_map is always equal to the direct field of the root page's role: > > - for shadow paging, direct_map is true if CR0.PG=0 and root_role.direct is > copied from cpu_mode.base.direct > > - for TDP, it is always true and root_role.direct is also always true > > - for shadow EPT, it is always false and root_role.direct is also always Uber nit, s/EPT/TDP to cover shadow NPT, which at this point we are 100% sure is indirect ;-) > false > > Signed-off-by: Paolo Bonzini Reviewed-by: Sean Christopherson