Re: [PATCH v2 11/25] KVM: x86/mmu: remove kvm_calc_shadow_root_page_role_common

Paolo Bonzini
2022-03-08T18:18:45Z

On 3/8/22 19:17, Sean Christopherson wrote:
>>> + role.base.direct = !____is_cr0_pg(regs);
>
> On a serious note, can we add a WARN_ON_ONCE(role.base.direct)? Not so much that
> the WARN will be helpful, but to document the subtle dependency? If the relevant
> code goes away in the end, ignore this requrest.

Ok, that can be done. Either that or !is_cr0_pg().

Paolo