From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DB8CC433F5 for ; Tue, 15 Mar 2022 10:37:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234839AbiCOKjG (ORCPT ); Tue, 15 Mar 2022 06:39:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233588AbiCOKjD (ORCPT ); Tue, 15 Mar 2022 06:39:03 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 6E65913D67 for ; Tue, 15 Mar 2022 03:37:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647340670; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/KyXBi502NBWJY1eIzGz6vA6KexTdmJyjzypUpAHTNE=; b=AYiLbc4VoDFKUfLmUoGH3A0KVDa+0BrjTL9nrCubyQt6x+0w0nLtYFv/EDZhSeWQbu9HK3 neuxei+yAuI7YaHSGy5W59XkxINXAau2lipiQ/cOsTO/EfLPSOKQyU7K9PUjjuvSl43S41 cAu5uQcL1zO8MJoq2rSlMKfKwB1GvFk= Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-500-q8ETB0KmMlqa7mvmAEB_AQ-1; Tue, 15 Mar 2022 06:37:49 -0400 X-MC-Unique: q8ETB0KmMlqa7mvmAEB_AQ-1 Received: by mail-pl1-f198.google.com with SMTP id n11-20020a170902d2cb00b0015331a5d02fso5140950plc.12 for ; Tue, 15 Mar 2022 03:37:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/KyXBi502NBWJY1eIzGz6vA6KexTdmJyjzypUpAHTNE=; b=X6GjJLGM4/mnEsn4OCqYw0G6/BXBkkVa9RtRULZTzWaXEsarMaZ1n6fLOApIL4njVA 3bpH0momVz8+QUIaqXrBfhLovQctgs4v1zdjtS15Xbrn7qeawhjikoI3Dz/3VXYEYkKz /Vpl3xAmhT0jnU6DMiB3s1XyeX4XSv2UTjPaq5Usgr7lkAi4RepyL9Ez0SqZmRczurJG kQEPWzArv9sXuYvCQtNcT3bK0zpDv2+vp6M703cPpsFfQqTQMz6S3C3OGiObcFrjYXWE BeKdEaTk028WUCDMzcDzZJxqGmfz+ybmJw63houYoI9GgbhZH9NH9XwUzE9fckNqoGyH GQ/Q== X-Gm-Message-State: AOAM530n/HWUqzxcPFB08A0KH61u9wDBJTyxnDueHTqfZY99aOytLVFs b7xaV5KMgh5CG7eQDmoTkiWyIF/UCQwMAPxrOqpuV4cbcTiArUIQcvedFuG8dopognhp/OGkajm aROt0/hBJF4fJ X-Received: by 2002:a17:902:864b:b0:14c:d45e:a77b with SMTP id y11-20020a170902864b00b0014cd45ea77bmr27271942plt.143.1647340668141; Tue, 15 Mar 2022 03:37:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwuwiZgnCw2OZfY3/17qI+R/Vwptjj6tRCpsQcLyxgK5e+0w7DucK4ECAsJZKeHLCwxh0Ejkg== X-Received: by 2002:a17:902:864b:b0:14c:d45e:a77b with SMTP id y11-20020a170902864b00b0014cd45ea77bmr27271914plt.143.1647340667879; Tue, 15 Mar 2022 03:37:47 -0700 (PDT) Received: from xz-m1.local ([191.101.132.43]) by smtp.gmail.com with ESMTPSA id lp13-20020a17090b4a8d00b001c18b1114c8sm2789942pjb.10.2022.03.15.03.37.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Mar 2022 03:37:47 -0700 (PDT) Date: Tue, 15 Mar 2022 18:37:38 +0800 From: Peter Xu To: David Matlack Cc: Paolo Bonzini , Marc Zyngier , Huacai Chen , Aleksandar Markovic , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Sean Christopherson , Andrew Jones , Ben Gardon , maciej.szmigiero@oracle.com, "moderated list:KERNEL VIRTUAL MACHINE FOR ARM64 (KVM/arm64)" , "open list:KERNEL VIRTUAL MACHINE FOR MIPS (KVM/mips)" , "open list:KERNEL VIRTUAL MACHINE FOR MIPS (KVM/mips)" , "open list:KERNEL VIRTUAL MACHINE FOR RISC-V (KVM/riscv)" , Peter Feiner Subject: Re: [PATCH v2 14/26] KVM: x86/mmu: Decouple rmap_add() and link_shadow_page() from kvm_vcpu Message-ID: References: <20220311002528.2230172-1-dmatlack@google.com> <20220311002528.2230172-15-dmatlack@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220311002528.2230172-15-dmatlack@google.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Fri, Mar 11, 2022 at 12:25:16AM +0000, David Matlack wrote: > Allow adding new entries to the rmap and linking shadow pages without a > struct kvm_vcpu pointer by moving the implementation of rmap_add() and > link_shadow_page() into inner helper functions. > > No functional change intended. > > Reviewed-by: Ben Gardon > Signed-off-by: David Matlack > --- > arch/x86/kvm/mmu/mmu.c | 43 +++++++++++++++++++++++++++--------------- > 1 file changed, 28 insertions(+), 15 deletions(-) > > diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c > index d7ad71be6c52..c57070ed157d 100644 > --- a/arch/x86/kvm/mmu/mmu.c > +++ b/arch/x86/kvm/mmu/mmu.c > @@ -725,9 +725,9 @@ static void mmu_free_memory_caches(struct kvm_vcpu *vcpu) > kvm_mmu_free_memory_cache(&vcpu->arch.mmu_page_header_cache); > } > > -static struct pte_list_desc *mmu_alloc_pte_list_desc(struct kvm_vcpu *vcpu) > +static struct pte_list_desc *mmu_alloc_pte_list_desc(struct kvm_mmu_memory_cache *cache) > { > - return kvm_mmu_memory_cache_alloc(&vcpu->arch.mmu_pte_list_desc_cache); > + return kvm_mmu_memory_cache_alloc(cache); > } Nit: same here, IMHO we could drop mmu_alloc_pte_list_desc() already.. Reviewed-by: Peter Xu -- Peter Xu