public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: Chenyi Qiang <chenyi.qiang@intel.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	Vitaly Kuznetsov <vkuznets@redhat.com>,
	Wanpeng Li <wanpengli@tencent.com>,
	Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
	Xiaoyao Li <xiaoyao.li@intel.com>,
	kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Tao Xu <tao3.xu@intel.com>
Subject: Re: [PATCH v5 2/3] KVM: VMX: Enable Notify VM exit
Date: Wed, 6 Apr 2022 18:54:56 +0000	[thread overview]
Message-ID: <Yk3iAKW1sdA4StiC@google.com> (raw)
In-Reply-To: <YkzgLGlCAG2ZwgqS@google.com>

On Wed, Apr 06, 2022, Sean Christopherson wrote:
> On Fri, Mar 18, 2022, Chenyi Qiang wrote:
> Ha, and I think skipping this path on VMX_EXIT_REASONS_FAILED_VMENTRY is also
> technically wrong.  That's still a VM-Exit, I'm pretty sure failed VM-Entry only
> skips the MSR load/store list processing (because the load lists on VM-Entry are
> processed after the final consistency checks).

Nope, I'm wrong, the SDM explicit states that only EXIT_QUALIFICATION is modified
on VM-Entry failure VM-Exits.  Which means we actually have the opposite bug as
KVM is clearing a bunch of fields.

  reply	other threads:[~2022-04-06 20:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-18  7:49 [PATCH v5 0/3] Introduce Notify VM exit Chenyi Qiang
2022-03-18  7:49 ` [PATCH v5 1/3] KVM: X86: Save&restore the triple fault request Chenyi Qiang
2022-04-05 23:31   ` Sean Christopherson
2022-04-05 23:44     ` Sean Christopherson
2022-04-06 21:15       ` Sean Christopherson
2022-04-07  6:12         ` Chenyi Qiang
2022-04-08  2:48           ` Sean Christopherson
2022-04-06 21:25       ` Sean Christopherson
2022-04-06  6:46     ` Chenyi Qiang
2022-04-06 21:51     ` Sean Christopherson
2022-03-18  7:49 ` [PATCH v5 2/3] KVM: VMX: Enable Notify VM exit Chenyi Qiang
2022-04-06  0:34   ` Sean Christopherson
2022-04-06 18:54     ` Sean Christopherson [this message]
2022-03-18  7:49 ` [PATCH v5 3/3] KVM: Add document for KVM_CAP_X86_NOTIFY_VMEXIT and KVM_EXIT_NOTIFY Chenyi Qiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yk3iAKW1sdA4StiC@google.com \
    --to=seanjc@google.com \
    --cc=chenyi.qiang@intel.com \
    --cc=jmattson@google.com \
    --cc=joro@8bytes.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=tao3.xu@intel.com \
    --cc=vkuznets@redhat.com \
    --cc=wanpengli@tencent.com \
    --cc=xiaoyao.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox