From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE47CC433F5 for ; Thu, 31 Mar 2022 19:02:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238250AbiCaTEp (ORCPT ); Thu, 31 Mar 2022 15:04:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238038AbiCaTEo (ORCPT ); Thu, 31 Mar 2022 15:04:44 -0400 Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC20B20DB01 for ; Thu, 31 Mar 2022 12:02:56 -0700 (PDT) Received: by mail-pl1-x629.google.com with SMTP id n18so430046plg.5 for ; Thu, 31 Mar 2022 12:02:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Btlfi9u0cv/7pW0yWqfr1LdiIwUsA5YGvmZWg/HVlkY=; b=R5ZihntLCRzvgu6ZJtpoWuH5yh8cT9Yt81Z7BDIdt626MFW9xrrQyJXziYt0Jv5oRU mFe75yFpqAYqZt4NDeXMRbjduKiAq4htdLcZmglBbWSjSGS/VrtaEDCLV1RqaWSmpRQZ Uv2NlghAkcDKup+FiOBA8/qEsYKNepX4DdW46etO9EottizjKLuoLn+y16qmXzCoRbVc TybS2OkK0RElfTCJW45I8LJ2/oYiVOtfpjyuRQVmWh4DFlXCtbyTwwbwdv3sKp3tn1nJ dsn6nlezNFIcXL06mbieB/VztJKJuMmRE/iUg8kvssRf3qAwruoBd6FVSGgGHW0lHGzO hKjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Btlfi9u0cv/7pW0yWqfr1LdiIwUsA5YGvmZWg/HVlkY=; b=UqA7c15YOEnzjxJI9HGZG2ur+s6Y3WEf7wG7D3YTuNnlVK64hbYubLVcSTnpmfzlal X7PcCRiA9mVpGrwycYejgthf+OohHPJR1CO6CbUEbQFuvZCL5R6o7KvuxmR6xAVg/R6I R75d4hF2R1uDXoRxkdNbvr07TWztOCQ5P6kQrWjmod0bEScdH+SkEct2hxV1nls6AVUn Db8R745KWpj/LQPRJit3/hvejvXtrcB5oRyJexKXW341SSj6/fJBWpfqh/gT26SEc5Nu Zb6KwIoe9XXRlFJolAAIsT14QlUcH0ihNqJVjkqXI/d27bRe6eGwUHVCgrsEPJCxXXUY 5h2w== X-Gm-Message-State: AOAM531rqQ3mJVqCYU3IMJ9SZv01Fr/4j1rd/9WJVVBRsDQ+FqVar+FW I4uhu7BZ/NRya+aXvl/vt0G1cQ== X-Google-Smtp-Source: ABdhPJwiwMc612ifEugRgefZeGQbTSzqzjIxRK0MRHNUAO+FYZ4sWZdI4SerXlLDAjDCNBi5jOybfQ== X-Received: by 2002:a17:902:a981:b0:156:52b2:40d6 with SMTP id bh1-20020a170902a98100b0015652b240d6mr5998107plb.34.1648753376099; Thu, 31 Mar 2022 12:02:56 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id p4-20020a637404000000b00375948e63d6sm84514pgc.91.2022.03.31.12.02.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Mar 2022 12:02:55 -0700 (PDT) Date: Thu, 31 Mar 2022 19:02:52 +0000 From: Sean Christopherson To: Peter Gonda Cc: Marc Orr , kvm list , Vitaly Kuznetsov , Paolo Bonzini , "Lendacky, Thomas" , "Singh, Brijesh" Subject: Re: [PATCH v3] KVM, SEV: Add KVM_EXIT_SHUTDOWN metadata for SEV-ES Message-ID: References: <20220330182821.2633150-1-pgonda@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, Mar 31, 2022, Peter Gonda wrote: > On Thu, Mar 31, 2022 at 12:54 PM Sean Christopherson wrote: > > > > On Thu, Mar 31, 2022, Peter Gonda wrote: > > > I'll make this 2 patches. This current patch and another to rate limit > > > this pr_info() I think this patch is doing a lot already so would > > > prefer to just add a second. Is that reasonable? > > > > I strongly prefer removing the pr_info() entirely. As Marc pointed out, the > > info is redundant when KVM properly reports the issue. And worse, the info is > > useless unless there's exactly one VM running. Even then, it doesn't capture > > which vCPU failed. This is exactly why Jim, myself, and others, have been pushing > > to avoid using dmesg to report guest errors. They're helpful for initial > > development, but dead weight for production, and if they're helpful for development > > then odds are good that having proper reporting in production would also be valuable. > > Sounds good to me. Is a second patch OK with you? I think we get a lot > of cryptic cpu run exit reasons so fixing this up when we remove > pr_infos would be good. This would be a good example without this > pr_info or this change you'd have no idea whats going on. As in, a second patch to remove the pr_info? Yeah, no objection.