public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Sean Christopherson <seanjc@google.com>
To: Jue Wang <juew@google.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: x86: Add support for CMCI and UCNA.
Date: Tue, 12 Apr 2022 16:57:03 +0000	[thread overview]
Message-ID: <YlWvX9JakRD7IzcD@google.com> (raw)
In-Reply-To: <CAPcxDJ7gJD-iC0usZj5U88V4JGUdQ=Bwt-DSgVWwSt7yTTz1AA@mail.gmail.com>

On Tue, Apr 12, 2022, Jue Wang wrote:
> On Tue, Apr 12, 2022 at 7:22 AM Jue Wang <juew@google.com> wrote:
> > > > +             return 0;
> > > > +
> > > > +     if (lapic_in_kernel(vcpu))
> > >
> > > Any reason to support UNCA injection without an in-kernel APIC?
> 
> Even without a viable path for CMCI signaling, the UCNA errors should
> still be logged in registers so it gives consistent semantics to
> hardware for e.g., MCE overflow checks on an MCE signaled later.

Right, what I was suggesting is that KVM reject the ioctl() if the VM doesn't
have an in-kernel APIC, i.e. force userspace to use KVM's local APIC if userspace
wants to also support UNCA injection.

Side topic, please trim your replies, i.e. delete all the unnecessary quoted context.

  reply	other threads:[~2022-04-12 16:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-23 18:28 [PATCH] KVM: x86: Add support for CMCI and UCNA Jue Wang
2022-04-10 16:56 ` Jue Wang
2022-04-11 19:08 ` Sean Christopherson
2022-04-12 14:22   ` Jue Wang
2022-04-12 14:29     ` Jue Wang
2022-04-12 16:57       ` Sean Christopherson [this message]
2022-04-12 16:54     ` Sean Christopherson
2022-04-12 17:44   ` Paolo Bonzini
2022-04-12 18:19     ` Sean Christopherson
2022-04-12 19:52       ` Jue Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YlWvX9JakRD7IzcD@google.com \
    --to=seanjc@google.com \
    --cc=juew@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox