From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60456C433EF for ; Thu, 14 Apr 2022 17:13:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244798AbiDNRQL (ORCPT ); Thu, 14 Apr 2022 13:16:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244206AbiDNRQA (ORCPT ); Thu, 14 Apr 2022 13:16:00 -0400 Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9FE5D1C933 for ; Thu, 14 Apr 2022 10:09:11 -0700 (PDT) Received: by mail-pl1-x634.google.com with SMTP id n18so5172293plg.5 for ; Thu, 14 Apr 2022 10:09:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=4DY38zt6SGkIm7qCLcszzp71RSWzFwtMpyIliN/cQdM=; b=HrLCRwTjmr1NLdCljzYlFvY6ttcg9ZrtnXkyJWNFBoKg1lC2/QDj1Z+HqZvgxXMN2V G/ztWyQPEVGIpLnJfwAxFwVck/NE2ulUg/uGXokN995N6hSa3mN3PVayPSMFW8vKBfRw oSQDq5IWpEzVn5Qdwe0YVQIwf8IIB9PkuC0X6muXYfk4xHhJ+zJq6Ct/P3qFrhR66dK6 xR4IG2ikIahi2HCqviegtE2R3opvSYUc7mxnyHqYJWHYCRUAKu7AH7SCDc8wuXurRI7Z U37GtOYH6KRYe8x+3itBTRIY/yHXi5DgGJho+agRoq0/QgAUZCtCs/ag60bH6EUV1j8g d1Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=4DY38zt6SGkIm7qCLcszzp71RSWzFwtMpyIliN/cQdM=; b=h4RnBzWPZfLMw/bpAjRDH8BVQ8RcToCApaoI4wCqYIad/AeXbZxR8LmVnVuCCu2pdQ vvnhnnDVyxdeOXodz8+2PzZ8CdUN2QUUYgG4TEMI6+jSXyGOd0b48WOMgSAwXkbxCAP/ uKpMalHfSbyrnV4hl+MPatyHOXeultoDJoUlFrL9LGURjcfyZTsGgbEmBDixsycVGVtK JjxnqJ97/3eJxeuhCHXGfqblTxBNQUPa48XE6RqCvOtxSgPUFon14175A8Y0HkaZduip FeEwmCdeoFMDCMWpYfO7s806g3c/nOcjAeXHRial4KdvUvxIaijkwz3Wr9eRYj0fvODc it/g== X-Gm-Message-State: AOAM533uudGwR1AXiUll2glHfdcOzvHJZZe2XI6iAFOFbp7qMU7ybtKG BEjuBjRVJ9uFMkI9GNMZbvDPBg== X-Google-Smtp-Source: ABdhPJxGEJznTdlqtjBF84pK5RGMzIwBmz4c+h6rdYXZeZrge2UBebitMJPG0Ztg01qkgDMtepmTEA== X-Received: by 2002:a17:902:7795:b0:157:c50:53a6 with SMTP id o21-20020a170902779500b001570c5053a6mr35811305pll.40.1649956150947; Thu, 14 Apr 2022 10:09:10 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id k8-20020aa790c8000000b00505d6016097sm449808pfk.94.2022.04.14.10.09.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Apr 2022 10:09:10 -0700 (PDT) Date: Thu, 14 Apr 2022 17:09:06 +0000 From: Sean Christopherson To: Paolo Bonzini Cc: Isaku Yamahata , isaku.yamahata@intel.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Jim Mattson , erdemaktas@google.com, Connor Kuehl Subject: Re: [RFC PATCH v5 092/104] KVM: TDX: Handle TDX PV HLT hypercall Message-ID: References: <6da55adb2ddb6f287ebd46aad02cfaaac2088415.1646422845.git.isaku.yamahata@intel.com> <282d4cd1-d1f7-663c-a965-af587f77ee5a@redhat.com> <8e0280ab-c7aa-5d01-a36f-93d0d0d79e25@redhat.com> <20220408045842.GI2864606@ls.amr.corp.intel.com> <27a59f1a-ea74-2d75-0739-5521e7638c68@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, Apr 11, 2022, Paolo Bonzini wrote: > On 4/8/22 16:51, Sean Christopherson wrote: > > > It also documents how it has to be used. So this looks more or less okay, > > > just rename "vmxip" to "interrupt_pending_delivery". > > > > If we're keeping the call back into SEAM, then this belongs in the path of > > apic_has_interrupt_for_ppr(), not in the HLT-exit path. To avoid multiple SEAMCALLS > > in a single exit, VCPU_EXREG_RVI can be added. > > But apic_has_interrupt_for_ppr takes a PPR argument and that is not > available. > > So I suppose you mean kvm_apic_has_interrupt? Yeah, I realized that when I actually tried to implement my idea in code :-) My hopefully-fully-thought-out idea for handling this: https://lore.kernel.org/all/YlBhuWElVRwYrrS+@google.com https://lore.kernel.org/all/YlBkiOmTGk8VlWFh@google.com