Re: [PATCH] KVM: x86/mmu: add lockdep check before lookup_address_in_mm()

Mingwei Zhang
2022-04-26T18:48:53Z

> I completely agree that lookup_address() and friends are unnecessarily fragile,
> but I think that attempting to harden them to fix this KVM bug will open a can
> of worms and end up delaying getting KVM fixed.

So basically, we need to:
- choose perf_get_page_size() instead of using any of the
lookup_address*() in mm.
- add a wrapper layer to adapt: 1) irq disabling/enabling and 2) size
-> level translation.

Agree?