Re: [PATCH kvmtool] Fixes: 0febaae00bb6 ("Add asm/kernel.h for riscv")

[Alexandru Elisei <alexandru.elisei@arm.com>]

Adding the kvmtool maintainers, I just noticed that they were missing.

On Mon, May 23, 2022 at 10:31:34AM +0100, Alexandru Elisei wrote:
> Hi,
> 
> When I started working on the heterogeneous PMU series, support for the
> riscv architecture wasn't merged in kvmtool, and after riscv was merged I
> missed adding the header file.
> 
> This indeed fixes this compilation error:
> 
> In file included from include/linux/rbtree.h:32,
>                  from include/kvm/devices.h:4,
>                  from include/kvm/pci.h:10,
>                  from include/kvm/vfio.h:6,
>                  from include/kvm/kvm-config.h:5,
>                  from include/kvm/kvm.h:6:
> include/linux/kernel.h:5:10: fatal error: asm/kernel.h: No such file or directory
>     5 | #include "asm/kernel.h"
>       |          ^~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> compilation terminated.
> make: *** [Makefile:484: builtin-balloon.o] Error 1
> 
> Would be nice to include it in the commit message, so people googling for
> that exact error message can come across this commit.
> 
> On Fri, May 20, 2022 at 11:09:46AM -0700, Dao Lu wrote:
> > Signed-off-by: Dao Lu <daolu@rivosinc.com>
> > ---
> >  riscv/include/asm/kernel.h | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> >  create mode 100644 riscv/include/asm/kernel.h
> > 
> > diff --git a/riscv/include/asm/kernel.h b/riscv/include/asm/kernel.h
> > new file mode 100644
> > index 0000000..a2a8d9e
> > --- /dev/null
> > +++ b/riscv/include/asm/kernel.h
> > @@ -0,0 +1,8 @@
> > +/* SPDX-License-Identifier: GPL-2.0 */
> > +
> > +#ifndef __ASM_KERNEL_H
> > +#define __ASM_KERNEL_H
> > +
> > +#define NR_CPUS	4096
> 
> In arch/riscv/Kconfig I see this:
> 
> config NR_CPUS
> 	int "Maximum number of CPUs (2-32)"
> 	range 2 32
> 	depends on SMP
> 	default "8"
> 
> Would you mind explaining where the 4096 number of CPUs comes from?
> 
> Thanks,
> Alex
> 
> > +
> > +#endif /* __ASM_KERNEL_H */
> > -- 
> > 2.36.0
> >