From: Sean Christopherson <seanjc@google.com>
To: Jim Mattson <jmattson@google.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Andrew Jones <drjones@redhat.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] KVM: selftests: Add a missing apostrophe in comment to show ownership
Date: Mon, 13 Jun 2022 19:32:23 +0000 [thread overview]
Message-ID: <YqeQx2fbdVVnRcxS@google.com> (raw)
In-Reply-To: <CALMp9eRBNqPrBMi_XDMMK8HpdoYRUfoe_jSVZAW80wSxWbDJVA@mail.gmail.com>
On Mon, Jun 13, 2022, Jim Mattson wrote:
> On Mon, Jun 13, 2022 at 12:01 PM Sean Christopherson <seanjc@google.com> wrote:
> >
> > Add an apostrophe in a comment about it being the caller's, not callers,
> > responsibility to free an object.
> >
> > Reported-by: Andrew Jones <drjones@redhat.com>
> > Fixes: 768e9a61856b ("KVM: selftests: Purge vm+vcpu_id == vcpu silliness")
> > Signed-off-by: Sean Christopherson <seanjc@google.com>
> > ---
> > tools/testing/selftests/kvm/lib/kvm_util.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c b/tools/testing/selftests/kvm/lib/kvm_util.c
> > index 39f2f5f1338f..0c550fb0dab2 100644
> > --- a/tools/testing/selftests/kvm/lib/kvm_util.c
> > +++ b/tools/testing/selftests/kvm/lib/kvm_util.c
> > @@ -1434,7 +1434,7 @@ void vcpu_run_complete_io(struct kvm_vcpu *vcpu)
> > /*
> > * Get the list of guest registers which are supported for
> > * KVM_GET_ONE_REG/KVM_SET_ONE_REG ioctls. Returns a kvm_reg_list pointer,
> > - * it is the callers responsibility to free the list.
> > + * it is the caller's responsibility to free the list.
> > */
> Shouldn't that be callers'? Or are you assuming there is only ever
> going to be one caller?
No? Regardless of the number of users of the function, for any given invocation
and allocation, there is exactly one caller.
next prev parent reply other threads:[~2022-06-13 20:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-13 16:19 [PATCH 0/4] KVM: selftests: Fixups for overhaul Sean Christopherson
2022-06-13 16:19 ` [PATCH 1/4] KVM: selftests: Add a missing apostrophe in comment to show ownership Sean Christopherson
2022-06-13 19:13 ` Jim Mattson
2022-06-13 19:32 ` Sean Christopherson [this message]
2022-06-13 19:35 ` Jim Mattson
2022-06-13 16:19 ` [PATCH 2/4] KVM: selftests: Call a dummy helper in VM/vCPU ioctls() to enforce type Sean Christopherson
2022-06-13 16:19 ` [PATCH 3/4] KVM: selftests: Drop a duplicate TEST_ASSERT() in vm_nr_pages_required() Sean Christopherson
2022-06-13 16:19 ` [PATCH 4/4] KVM: selftests: Use kvm_has_cap(), not kvm_check_cap(), where possible Sean Christopherson
2022-06-14 7:51 ` [PATCH 0/4] KVM: selftests: Fixups for overhaul Andrew Jones
2022-06-14 7:52 ` Andrew Jones
2022-06-14 16:44 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqeQx2fbdVVnRcxS@google.com \
--to=seanjc@google.com \
--cc=drjones@redhat.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox