From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5ABABC43334 for ; Tue, 14 Jun 2022 14:44:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236244AbiFNOoU (ORCPT ); Tue, 14 Jun 2022 10:44:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356249AbiFNOnm (ORCPT ); Tue, 14 Jun 2022 10:43:42 -0400 Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5728E1A391 for ; Tue, 14 Jun 2022 07:43:39 -0700 (PDT) Received: by mail-pj1-x1029.google.com with SMTP id v11-20020a17090a4ecb00b001e2c5b837ccso11966543pjl.3 for ; Tue, 14 Jun 2022 07:43:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=BjMtNFrHev59P8JrA6x8VC/0SCbAjmaVxOnzjl9xyPo=; b=Irznq41D4JwzODMvCXf615k4IPwoT+vhOuBFpX/HXdCybZvjLw0Lr5OLG3jsA0bVMS /16XhDGLJnqia6N6qcTeSXMWzDb2YMRq9UgQtL87ZmBWWKltGVUQackAegnoRONEebqb ahlEwP8S9yr8YzRfnXfwy+Q4qwfS19E+byrqNDhylt3wS/3R2IubBltEE6iPWJ7srJ7P FJXs0W/gOHaR52LWWWyPZvS8sEGZNqxtG9YP4DcVF3RVUJN58Q8kwY0ytuB0BsAdcERA FVi9LrYu7N3eW25n64y91pUgugjahf6tBxTDh53hot9WxhfpiMV4jBxdSA/nNOhgE6v/ eaGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=BjMtNFrHev59P8JrA6x8VC/0SCbAjmaVxOnzjl9xyPo=; b=OSUmiaHjFrDORDyM5CsXodtsSFsvihvhbc8LDxfgTh7qHBDxOVmW0lI1araWB3O424 lTnSLwtvwjIcYdhCiPsOMGMhIh3PRfViQA8Uj8P57UQ4ol7tLQFBbUh17OhegGpV6iiu B1fq0f8ZInPD1oDReldL+kfArHIi1klFOIw31+AmwyKZSZRF9r+kAUCJAV6d/TAzi5bt FgHbERfeOBK8bF3eqOaPVCq6Bmlp+9GEol+vkjrhdMhRxm2SqjTK+VzXW4kA11q+ryzY GN4pErqAmFc9lIoee0VHXKYauvT2JSBjW8Fp5Kvv2oYvocLRXBLKDU7j5iJFk1UuZO44 Youw== X-Gm-Message-State: AJIora+wkJKew9ZsBAd7DSsq1h02wt9hW+2+84si7Md8STwXCDPNmhN+ 3cmdqHPD//K7v6IqiY1mDQXDlw== X-Google-Smtp-Source: AGRyM1uQDmd+XTaC6ky7C2ZAFwv+iO59Og2nuLOoRelbEx7do9z41dETqk4zuyxaCtYrGu0CnaD3Rg== X-Received: by 2002:a17:90a:a016:b0:1ea:97b9:6c1b with SMTP id q22-20020a17090aa01600b001ea97b96c1bmr4985018pjp.212.1655217818620; Tue, 14 Jun 2022 07:43:38 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id t64-20020a628143000000b0051bbc198f3fsm7975713pfd.13.2022.06.14.07.43.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jun 2022 07:43:38 -0700 (PDT) Date: Tue, 14 Jun 2022 14:43:34 +0000 From: Sean Christopherson To: Andrew Jones Cc: kvm@vger.kernel.org, pbonzini@redhat.com Subject: Re: [PATCH] KVM: selftests: kvm_binary_stats_test: Fix index expressions Message-ID: References: <20220614081041.2571511-1-drjones@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220614081041.2571511-1-drjones@redhat.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Tue, Jun 14, 2022, Andrew Jones wrote: > kvm_binary_stats_test accepts two arguments, the number of vms > and number of vcpus. If these inputs are not equal then the > test would likely crash for one reason or another due to using > miscalculated indices for the vcpus array. Fix the index > expressions by swapping the use of i and j. > > Signed-off-by: Andrew Jones > --- Thanks! I had done this locally but lost track of it when updating kvm/queue. Reviewed-by: Sean Christopherson