[kvm:queue 5/184] arch/x86/kvm/svm/avic.c:913:6: warning: shift count >= width of type

[kvm:queue 5/184] arch/x86/kvm/svm/avic.c:913:6: warning: shift count >= width of type

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/virt/kvm/kvm.git queue
head:   8baacf67c76c560fed954ac972b63e6e59a6fba0
commit: 3743c2f0251743b8ae968329708bbbeefff244cf [5/184] KVM: x86: inhibit APICv/AVIC on changes to APIC ID or APIC base
config: i386-buildonly-randconfig-r002-20220613 (https://download.01.org/0day-ci/archive/20220613/202206132237.17DFkdFl-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project d378268ead93c85803c270277f0243737b536ae7)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/virt/kvm/kvm.git/commit/?id=3743c2f0251743b8ae968329708bbbeefff244cf
        git remote add kvm https://git.kernel.org/pub/scm/virt/kvm/kvm.git
        git fetch --no-tags kvm queue
        git checkout 3743c2f0251743b8ae968329708bbbeefff244cf
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash arch/x86/kvm/ drivers/gpu/drm/amd/display/amdgpu_dm/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> arch/x86/kvm/svm/avic.c:913:6: warning: shift count >= width of type [-Wshift-count-overflow]
                             BIT(APICV_INHIBIT_REASON_SEV      |
                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/vdso/bits.h:7:26: note: expanded from macro 'BIT'
   #define BIT(nr)                 (UL(1) << (nr))
                                          ^  ~~~~
   1 warning generated.


vim +913 arch/x86/kvm/svm/avic.c

   902	
   903	bool avic_check_apicv_inhibit_reasons(enum kvm_apicv_inhibit reason)
   904	{
   905		ulong supported = BIT(APICV_INHIBIT_REASON_DISABLE) |
   906				  BIT(APICV_INHIBIT_REASON_ABSENT) |
   907				  BIT(APICV_INHIBIT_REASON_HYPERV) |
   908				  BIT(APICV_INHIBIT_REASON_NESTED) |
   909				  BIT(APICV_INHIBIT_REASON_IRQWIN) |
   910				  BIT(APICV_INHIBIT_REASON_PIT_REINJ) |
   911				  BIT(APICV_INHIBIT_REASON_X2APIC) |
   912				  BIT(APICV_INHIBIT_REASON_BLOCKIRQ) |
 > 913				  BIT(APICV_INHIBIT_REASON_SEV      |
   914				  BIT(APICV_INHIBIT_REASON_APIC_ID_MODIFIED) |
   915				  BIT(APICV_INHIBIT_REASON_APIC_BASE_MODIFIED));
   916	
   917		return supported & BIT(reason);
   918	}
   919	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

Re: [kvm:queue 5/184] arch/x86/kvm/svm/avic.c:913:6: warning: shift count >= width of type

[Paolo Bonzini]

On 6/13/22 16:49, kernel test robot wrote:
>     902	
>     903	bool avic_check_apicv_inhibit_reasons(enum kvm_apicv_inhibit reason)
>     904	{
>     905		ulong supported = BIT(APICV_INHIBIT_REASON_DISABLE) |
>     906				  BIT(APICV_INHIBIT_REASON_ABSENT) |
>     907				  BIT(APICV_INHIBIT_REASON_HYPERV) |
>     908				  BIT(APICV_INHIBIT_REASON_NESTED) |
>     909				  BIT(APICV_INHIBIT_REASON_IRQWIN) |
>     910				  BIT(APICV_INHIBIT_REASON_PIT_REINJ) |
>     911				  BIT(APICV_INHIBIT_REASON_X2APIC) |
>     912				  BIT(APICV_INHIBIT_REASON_BLOCKIRQ) |
>   > 913				  BIT(APICV_INHIBIT_REASON_SEV      |
>     914				  BIT(APICV_INHIBIT_REASON_APIC_ID_MODIFIED) |
>     915				  BIT(APICV_INHIBIT_REASON_APIC_BASE_MODIFIED));

Ouch, saw this right after sending a pull request. :(

I'll do the fixup.

Paolo

Re: [kvm:queue 5/184] arch/x86/kvm/svm/avic.c:913:6: warning: shift count >= width of type

[Sean Christopherson]

On Tue, Jun 14, 2022, Paolo Bonzini wrote:
> On 6/13/22 16:49, kernel test robot wrote:
> >     902	
> >     903	bool avic_check_apicv_inhibit_reasons(enum kvm_apicv_inhibit reason)
> >     904	{
> >     905		ulong supported = BIT(APICV_INHIBIT_REASON_DISABLE) |
> >     906				  BIT(APICV_INHIBIT_REASON_ABSENT) |
> >     907				  BIT(APICV_INHIBIT_REASON_HYPERV) |
> >     908				  BIT(APICV_INHIBIT_REASON_NESTED) |
> >     909				  BIT(APICV_INHIBIT_REASON_IRQWIN) |
> >     910				  BIT(APICV_INHIBIT_REASON_PIT_REINJ) |
> >     911				  BIT(APICV_INHIBIT_REASON_X2APIC) |
> >     912				  BIT(APICV_INHIBIT_REASON_BLOCKIRQ) |
> >   > 913				  BIT(APICV_INHIBIT_REASON_SEV      |
> >     914				  BIT(APICV_INHIBIT_REASON_APIC_ID_MODIFIED) |
> >     915				  BIT(APICV_INHIBIT_REASON_APIC_BASE_MODIFIED));
> 
> Ouch, saw this right after sending a pull request. :(

KVM_WERROR=y is your friend.  Or in my case, my enemy for the last few days :-D

Re: [kvm:queue 5/184] arch/x86/kvm/svm/avic.c:913:6: warning: shift count >= width of type

[Paolo Bonzini]

On 6/14/22 17:01, Sean Christopherson wrote:
>> Ouch, saw this right after sending a pull request.:(
> KVM_WERROR=y is your friend.  Or in my case, my enemy for the last few days:-D
> 

I have it of course, but this one didn't reproduce on 64-bit systems as 
far as I can see.

Paolo