From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3966BC43334 for ; Thu, 7 Jul 2022 17:20:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236136AbiGGRUD (ORCPT ); Thu, 7 Jul 2022 13:20:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235803AbiGGRUC (ORCPT ); Thu, 7 Jul 2022 13:20:02 -0400 Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61C5C3207D for ; Thu, 7 Jul 2022 10:20:01 -0700 (PDT) Received: by mail-pg1-x535.google.com with SMTP id bf13so6645270pgb.11 for ; Thu, 07 Jul 2022 10:20:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=wHDkdTAfWsoyslrvAYsfjRDZIjkF9cFNI1XJMwcL7ik=; b=N/22i/c+x0sT6c/G5v+eK+P3M95kFG2bYI613m+5/VgRJn53KVP5angDyfnc+P+xIu 6qa4TQf0TBpr7qRgXqnFdmboeahHnnfvhQ5FhKcbd7ovQ/y7waxFzejBsWnkoyvjyV7z 9PNRiNLLuhbuMt4EzpiVv9ktacEvhCpm3uv2hXeAk72+NFooipgrlG6qQ0arAOP9ENmv nGCipLBMyBZQL8/letrIRr4U+U7u3roGM2GbUri+EyUqgP1QgfTFCmza59jU2WVfypjC mtMnFoT1Y3ruPypNvfjflegcEqfWu+N18rEtXXuRoA1qTDrJ67Hy/BjHdU9yShcywh7u +/+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=wHDkdTAfWsoyslrvAYsfjRDZIjkF9cFNI1XJMwcL7ik=; b=6p7lRtaijW43MWSbGnIKZi4m0l0VWMGFwerF1a+XEeAjCvAIdSN9yOs/NqJrYheL5H gXMTfZzpknMJLM+IVbBAk1EKJuM9OtjLZuLSkXPmOIb+BWq6SXls2l8PGgXfuaIG+r62 w2Y/h4Ip8oK38bAbh+TtnEfdhND36dyGaPCwhWKxVuA+Ab++zh088JnQ6UkEnlvLxXfk YJXXyPXgf854JDUObJQK3gGnHeolWuCYR2kQnGUteshf9Dnad2INh9OpqhOm30lWZRTT OZrsX0h3xags02b9mYJncxIz9GLXG7yLWpHo6Ba3uwJwxaPClLb/ZoODQT/YGpCjmIlq Wrjg== X-Gm-Message-State: AJIora+9BWUbQMdAZYOGql2cxDLZIcep+gZzGo0wwjjsA0Yx5zAJ7+yF sbTwzxvQxqtleE8yakSJsjB/DA== X-Google-Smtp-Source: AGRyM1s8F4+upWWb3wse7GLP7QT3oixsb5B56+9euHVQUuWnG78Hv8TcKOHKdaiNXYJMYl4zGz177w== X-Received: by 2002:a17:90b:38ce:b0:1ef:c5bd:e2bd with SMTP id nn14-20020a17090b38ce00b001efc5bde2bdmr6602223pjb.149.1657214400825; Thu, 07 Jul 2022 10:20:00 -0700 (PDT) Received: from google.com (123.65.230.35.bc.googleusercontent.com. [35.230.65.123]) by smtp.gmail.com with ESMTPSA id w63-20020a623042000000b005252ab25363sm1419412pfw.206.2022.07.07.10.20.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Jul 2022 10:20:00 -0700 (PDT) Date: Thu, 7 Jul 2022 17:19:56 +0000 From: Sean Christopherson To: Jim Mattson Cc: Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Oliver Upton , Peter Shier Subject: Re: [PATCH v2 06/21] KVM: x86: Treat #DBs from the emulator as fault-like (code and DR7.GD=1) Message-ID: References: <20220614204730.3359543-1-seanjc@google.com> <20220614204730.3359543-7-seanjc@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, Jul 06, 2022, Jim Mattson wrote: > On Tue, Jun 14, 2022 at 1:47 PM Sean Christopherson wrote: > > > > Add a dedicated "exception type" for #DBs, as #DBs can be fault-like or > > trap-like depending the sub-type of #DB, and effectively defer the > > decision of what to do with the #DB to the caller. > > > > For the emulator's two calls to exception_type(), treat the #DB as > > fault-like, as the emulator handles only code breakpoint and general > > detect #DBs, both of which are fault-like. > > Does this mean that data and I/O breakpoint traps are just dropped? Yep. > Are there KVM errata for those misbehaviors? Nope. > What about single-stepping? Is that handled outwith the emulator? Single-step is emulated, and AFAIK there are no _known_ bugs.