* [PATCH kvm-unit-tests] x86: fix clang warning
@ 2022-07-26 15:03 Paolo Bonzini
2022-07-26 17:23 ` Sean Christopherson
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Bonzini @ 2022-07-26 15:03 UTC (permalink / raw)
To: kvm
x86/vmx.c:1502:69: error: use of logical
---
x86/vmx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/x86/vmx.c b/x86/vmx.c
index fd845d7..a13f2c9 100644
--- a/x86/vmx.c
+++ b/x86/vmx.c
@@ -1499,7 +1499,8 @@ static int test_vmxon_bad_cr(int cr_number, unsigned long orig_cr,
* bit set at all levels.
*/
if ((cr_number == 0 && (bit == X86_CR0_PE || bit == X86_CR0_PG)) ||
- (cr_number == 4 && (bit == X86_CR4_PAE || bit == X86_CR4_SMAP || X86_CR4_SMEP)))
+ (cr_number == 4 && (bit == X86_CR4_PAE || bit == X86_CR4_SMAP ||
+ bit == X86_CR4_SMEP)))
continue;
if (!(bit & required1) && !(bit & disallowed1)) {
--
2.36.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH kvm-unit-tests] x86: fix clang warning
2022-07-26 15:03 [PATCH kvm-unit-tests] x86: fix clang warning Paolo Bonzini
@ 2022-07-26 17:23 ` Sean Christopherson
0 siblings, 0 replies; 2+ messages in thread
From: Sean Christopherson @ 2022-07-26 17:23 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: kvm
On Tue, Jul 26, 2022, Paolo Bonzini wrote:
> x86/vmx.c:1502:69: error: use of logical
> ---
Sorry :-(
Reviewed-by: Sean Christopherson <seanjc@google.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-26 17:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-26 15:03 [PATCH kvm-unit-tests] x86: fix clang warning Paolo Bonzini
2022-07-26 17:23 ` Sean Christopherson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).