From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DF40C04A68 for ; Wed, 27 Jul 2022 18:54:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234699AbiG0SyP (ORCPT ); Wed, 27 Jul 2022 14:54:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36654 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233927AbiG0Sxo (ORCPT ); Wed, 27 Jul 2022 14:53:44 -0400 Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 847134F69A for ; Wed, 27 Jul 2022 10:51:57 -0700 (PDT) Received: by mail-pj1-x102c.google.com with SMTP id o14-20020a17090a4b4e00b001f2f2b61be5so2864747pjl.4 for ; Wed, 27 Jul 2022 10:51:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ofQJSU73p95X2wrdmZUMPm40+n8Nm3wKjXkzp0hyl7g=; b=XmZYEReTJM3L7fsK9TWdOjLKfiG9/dDjYBZctld/7WfLBTg+GpLZP2jGoashiK9oHp eBm/HwHa2XW04PRn2hCGJt0upBpvHEYVpCiwCg5X8G7IXxs3Cs0Qndk/EIJ4N41pWu+A uj/eS/a5c+iIOwKlO+a6Ue5DQFtzabKxozxkXlq7c4Djl4nvCbCTiPJEz0IPCeP4+Pkt JdbgOOGW8+EXaNOv72WVWEIDXEXNtyPuUytZlnDFRZxXNdJ1uouTqywvt6dIWUjnbgDE wueqn9+4Fqyt/EdrrtSAPE1Z1/Hvx9ZgJBSj1NFEQ7ndSpcJWCcjqMPUbVbb5bZRzr/V Jq9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ofQJSU73p95X2wrdmZUMPm40+n8Nm3wKjXkzp0hyl7g=; b=ZlIQmQb2KRjsMBIOWgbsEryC9MHVR3H3awAdgkRhp4/yzpDB4JF81OEjwHsz2B3eFq heY7gOtpE+V3gIYjxVlZG1BraY8qt6tuTJMsn03y5QnaTDrCP4sEDm9DoqOAKgNHSShO hXn0BEkhF1ul1pkKsrnZ3Oghtptb/Zw4IC2I0VEGUBOhypYRazwcmy+F30+v+Bu2sN1G vYOmguv/unPYMVIDP8PKWpWhw+3g4C4zmFFDQ1+ZKIMI9AWmrMKjPVPyCHM6m0CCDH5Z xmhOxE2iIAh+bGvwSshM9Kb/3iLdF/ckDPYPJYnHjLOnDKEA9fnyHMcvzpbMie/szmKp GwEg== X-Gm-Message-State: AJIora8DL1X8z0F9tq6FCfadIqUwcFxCDzOYTvML02koSxcUvIG5iIsN sItNXr8lBnMCWvyAoOvgQ9NPRA== X-Google-Smtp-Source: AGRyM1vV8JXIJhF+qJqT0Dzy5IsQQCabBg+/G8IdfcmHqMbpVts8NvQp/ObpyQrGa62H8vdRbxZsvg== X-Received: by 2002:a17:90a:728f:b0:1f2:4a4c:6c39 with SMTP id e15-20020a17090a728f00b001f24a4c6c39mr5912043pjg.43.1658944316853; Wed, 27 Jul 2022 10:51:56 -0700 (PDT) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id q29-20020aa7961d000000b0052b8240840dsm14703835pfg.145.2022.07.27.10.51.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Jul 2022 10:51:56 -0700 (PDT) Date: Wed, 27 Jul 2022 17:51:52 +0000 From: Sean Christopherson To: David Matlack Cc: Hao Peng , Paolo Bonzini , kvm list , LKML Subject: Re: [PATCH] kvm: mmu: fix typos in struct kvm_arch Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Wed, Jul 27, 2022, David Matlack wrote: > On Wed, Jul 27, 2022 at 3:58 AM Hao Peng wrote: > > > > From: Peng Hao > > > > No 'kvmp_mmu_pages', it should be 'kvm_mmu_page'. And > > struct kvm_mmu_pages and struct kvm_mmu_page are different structures, > > here should be kvm_mmu_page. > > kvm_mmu_pages is defined in arch/x86/kvm/mmu/mmu.c. > > > > Signed-off-by: Peng Hao > > --- > > arch/x86/include/asm/kvm_host.h | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h > > index e8281d64a431..205a9f374e14 100644 > > --- a/arch/x86/include/asm/kvm_host.h > > +++ b/arch/x86/include/asm/kvm_host.h > > @@ -1272,8 +1272,8 @@ struct kvm_arch { > > bool tdp_mmu_enabled; > > > > /* > > - * List of struct kvm_mmu_pages being used as roots. > > - * All struct kvm_mmu_pages in the list should have > > + * List of struct kvm_mmu_page being used as roots. > > I agree that "struct s" is a bad/misleading way to make a struct > plural in comments. The way I prefer to do it is " structs". > That avoids changing the and still makes it clear it's plural. +1, I like that approach. FWIW, "struct kvm_mmu_pages" will likely be renamed in the not-too-distant future[*], but I think it's still worth changing this to follow David's suggestion. [*] https://lore.kernel.org/all/20220605064342.309219-13-jiangshanlai@gmail.com