From: David Matlack <dmatlack@google.com>
To: Hao Peng <flyingpenghao@gmail.com>
Cc: pbonzini@redhat.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Sean Christopherson <seanjc@google.com>
Subject: Re: [PATCH v2] kvm: mmu: fix typos in struct kvm_arch
Date: Thu, 28 Jul 2022 09:16:50 -0700 [thread overview]
Message-ID: <YuK2ci/LJ2BTHqah@google.com> (raw)
In-Reply-To: <CAPm50aLBuq+zH9VHNDGLiB6Kqwwapus+dFwNqiOm8kruzPnouQ@mail.gmail.com>
On Thu, Jul 28, 2022 at 06:37:24PM +0800, Hao Peng wrote:
> From: Peng Hao <flyingpeng@tencent.com>
>
> No 'kvmp_mmu_pages', it should be 'kvm_mmu_page'. And
> struct kvm_mmu_pages and struct kvm_mmu_page are different structures,
> here should be kvm_mmu_page.
> kvm_mmu_pages is defined in arch/x86/kvm/mmu/mmu.c.
>
> Suggested-by: David Matlack <dmatlack@google.com>
> Signed-off-by: Peng Hao <flyingpeng@tencent.com>
Reviewed-by: David Matlack <dmatlack@google.com>
> ---
> arch/x86/include/asm/kvm_host.h | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
> index e8281d64a431..e67b2f602fb2 100644
> --- a/arch/x86/include/asm/kvm_host.h
> +++ b/arch/x86/include/asm/kvm_host.h
> @@ -1272,8 +1272,8 @@ struct kvm_arch {
> bool tdp_mmu_enabled;
>
> /*
> - * List of struct kvm_mmu_pages being used as roots.
> - * All struct kvm_mmu_pages in the list should have
> + * List of kvm_mmu_page structs being used as roots.
> + * All kvm_mmu_page structs in the list should have
> * tdp_mmu_page set.
> *
> * For reads, this list is protected by:
> @@ -1292,8 +1292,8 @@ struct kvm_arch {
> struct list_head tdp_mmu_roots;
>
> /*
> - * List of struct kvmp_mmu_pages not being used as roots.
> - * All struct kvm_mmu_pages in the list should have
> + * List of kvm_mmu_page structs not being used as roots.
> + * All kvm_mmu_page structs in the list should have
> * tdp_mmu_page set and a tdp_mmu_root_count of 0.
> */
> struct list_head tdp_mmu_pages;
> @@ -1303,9 +1303,9 @@ struct kvm_arch {
> * is held in read mode:
> * - tdp_mmu_roots (above)
> * - tdp_mmu_pages (above)
> - * - the link field of struct kvm_mmu_pages used by the TDP MMU
> + * - the link field of kvm_mmu_page structs used by the TDP MMU
> * - lpage_disallowed_mmu_pages
> - * - the lpage_disallowed_link field of struct kvm_mmu_pages used
> + * - the lpage_disallowed_link field of kvm_mmu_page structs used
> * by the TDP MMU
> * It is acceptable, but not necessary, to acquire this lock when
> * the thread holds the MMU lock in write mode.
> --
> 2.27.0
prev parent reply other threads:[~2022-07-28 16:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-28 10:37 [PATCH v2] kvm: mmu: fix typos in struct kvm_arch Hao Peng
2022-07-28 16:16 ` David Matlack [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuK2ci/LJ2BTHqah@google.com \
--to=dmatlack@google.com \
--cc=flyingpenghao@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox