Re: [PATCH v3 2/3] vfio/ccw: Remove FSM Close from remove handlers

[Jason Gunthorpe <jgg@nvidia.com>]

On Thu, Jul 28, 2022 at 10:49:13PM +0200, Eric Farman wrote:
> Now that neither vfio_ccw_sch_probe() nor vfio_ccw_mdev_probe()
> affect the FSM state, it doesn't make sense for their _remove()
> counterparts try to revert things in this way. Since the FSM open
> and close are handled alongside MDEV open/close, these are
> unnecessary.
> 
> Signed-off-by: Eric Farman <farman@linux.ibm.com>
> Reviewed-by: Matthew Rosato <mjrosato@linux.ibm.com>
> ---
>  drivers/s390/cio/vfio_ccw_drv.c | 1 -
>  drivers/s390/cio/vfio_ccw_ops.c | 2 --
>  2 files changed, 3 deletions(-)

When I first saw this I wondered if the CLOSE might be to expedite the
userspace closing the FD or something, but we have ops->request()
which is supposed to be doing that, so it doesn't really make sense
even if that was the issue.

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason