kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Colton Lewis <coltonlewis@google.com>
To: kvm@vger.kernel.org
Cc: pbonzini@redhat.com, maz@kernel.org, dmatlack@google.com,
	seanjc@google.com, oupton@google.com, ricarkol@google.com
Subject: Re: [PATCH v2 3/3] KVM: selftests: Randomize page access order.
Date: Thu, 18 Aug 2022 21:41:48 +0000	[thread overview]
Message-ID: <Yv6yHCmtdJCOpZZM@google.com> (raw)
In-Reply-To: <20220817214146.3285106-4-coltonlewis@google.com>

On Wed, Aug 17, 2022 at 09:41:46PM +0000, Colton Lewis wrote:
> diff --git a/tools/testing/selftests/kvm/dirty_log_perf_test.c b/tools/testing/selftests/kvm/dirty_log_perf_test.c
> index 9226eeea79bc..af9754bda0a4 100644
> --- a/tools/testing/selftests/kvm/dirty_log_perf_test.c
> +++ b/tools/testing/selftests/kvm/dirty_log_perf_test.c
>  	while ((opt = getopt(argc, argv, "eghi:p:m:nb:v:or:s:x:w:")) != -1) {
>  		switch (opt) {
> +		case 'a':
> +			p.random_access = true;
> +			break;
>  		case 'e':
>  			/* 'e' is for evil. */
>  			run_vcpus_while_disabling_dirty_logging = true;

Was double checking this and forgot to add an "a" to the getopt
string. This is small enough that I will wait for the rest to get more
eyes before rerolling the patch.

  reply	other threads:[~2022-08-18 21:41 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-17 21:41 [PATCH v2 0/3] Randomize memory access of dirty_log_perf_test Colton Lewis
2022-08-17 21:41 ` [PATCH v2 1/3] KVM: selftests: Create source of randomness for guest code Colton Lewis
2022-08-26 21:58   ` David Matlack
2022-08-30 19:01     ` Colton Lewis
2022-09-01 17:52       ` Ricardo Koller
2022-09-01 18:22         ` Sean Christopherson
2022-09-02 11:20           ` Andrew Jones
2022-09-01 17:37   ` Ricardo Koller
2022-08-17 21:41 ` [PATCH v2 2/3] KVM: selftests: Randomize which pages are written vs read Colton Lewis
2022-08-26 22:13   ` David Matlack
2022-08-30 19:02     ` Colton Lewis
2022-09-08 18:51       ` David Matlack
2022-09-08 19:46         ` Colton Lewis
2022-09-08 19:52           ` David Matlack
2022-08-17 21:41 ` [PATCH v2 3/3] KVM: selftests: Randomize page access order Colton Lewis
2022-08-18 21:41   ` Colton Lewis [this message]
2022-08-26 22:20   ` David Matlack
2022-08-30 19:02     ` Colton Lewis
2022-09-01 17:43   ` Ricardo Koller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yv6yHCmtdJCOpZZM@google.com \
    --to=coltonlewis@google.com \
    --cc=dmatlack@google.com \
    --cc=kvm@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=oupton@google.com \
    --cc=pbonzini@redhat.com \
    --cc=ricarkol@google.com \
    --cc=seanjc@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).