From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C127C25B0C for ; Mon, 8 Aug 2022 15:28:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243636AbiHHP2G (ORCPT ); Mon, 8 Aug 2022 11:28:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40350 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243316AbiHHP1y (ORCPT ); Mon, 8 Aug 2022 11:27:54 -0400 Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0976214005 for ; Mon, 8 Aug 2022 08:27:54 -0700 (PDT) Received: by mail-pf1-x431.google.com with SMTP id b133so8392736pfb.6 for ; Mon, 08 Aug 2022 08:27:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=6EhfGnyFyfo/ortCKW/6YMzIhO+eS1k9nO7B1q/r9pQ=; b=ipcWPQ4r5SOTmHdFaWDyzYl7sr/T8mVvXFrXPnKe3sXnhoCaUiHdceGHpYs4VoIT4g egYf2m1+rJ3W9RLYDihkilDg76flKhNbU2JozYCXUnD0YqnDdswjFiaIonr1YIYriaiu BW81ij6knRBoY9s9PatXvqOPnOs1NdC/VP+KabIrtHffpoki1hBP98jMiRPJZCZLwGdp 7tYLL47JtnfP25Y87U5onjHwpwQSe0jHZIXb3Y4I/VW+kJ7tfnRHWj/N2gji9wf/CGp8 OYyudyJObGevxU494U7SHLlOxaW4vf6rDWAP0tkFqu2sq6juFi8cI7mo5tYXuDi1mhhW oMEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=6EhfGnyFyfo/ortCKW/6YMzIhO+eS1k9nO7B1q/r9pQ=; b=CfOzaC52L+fZCwyZw1xh23oW8j30QL7+YBVs5uO3s6nGbIuz5GXMikHvNWR4/5IbmI Wl2VH+KfEmevlfrM6FvIyJJVmM0s1AcZnqS5O57XVUgkclmyG+bLy++QzWOUg/bsZxkm 10U8nU1KdahyZFEf6vPjb4fzEyyq0/StXpCRqu+u9op8ZSVcOHNsMX5OzRZdFF2zimRi ++IFj5bn95IllciSBetnE66SEKgzlgtipJgC5CysT6ZZ/9TqKZQHnsloCnXifRKkjsn0 QmZsaGJTTbXXkw5WAHCGN7WrHmznbiEQsqGUnxlBIpaZzg0C7dv7FQ3VtcP2z89tE0jm wv+g== X-Gm-Message-State: ACgBeo2VI2KI5WNV62AtyDJ7ppMHNLyABGOXVbIyWTu7j46AfvJewgZI 8a23xMOYgNrqF3UkZF1pktip5nh2EZkDSw== X-Google-Smtp-Source: AA6agR4Rnf8A+8xtrvnphN11wUQN7ICXf7ikA7BaMe/wYY9EnMpRPjODRrEy9Ai4TjucpuH/tIgKlQ== X-Received: by 2002:a63:6304:0:b0:41c:1926:2aa9 with SMTP id x4-20020a636304000000b0041c19262aa9mr15723014pgb.425.1659972473399; Mon, 08 Aug 2022 08:27:53 -0700 (PDT) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id 19-20020a170902c21300b0016be368fb30sm8758280pll.212.2022.08.08.08.27.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Aug 2022 08:27:52 -0700 (PDT) Date: Mon, 8 Aug 2022 15:27:48 +0000 From: Sean Christopherson To: Michal Luczaj Cc: kvm@vger.kernel.org, pbonzini@redhat.com, shuah@kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [kvm-unit-tests PATCH v2 1/5] x86: emulator.c cleanup: Save and restore exception handlers Message-ID: References: <20220807142832.1576-1-mhal@rbox.co> <20220807142832.1576-2-mhal@rbox.co> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220807142832.1576-2-mhal@rbox.co> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Sun, Aug 07, 2022, Michal Luczaj wrote: > Users of handle_exception() should always save and restore the handlers. Might be worth calling out that #UD is intentionally left alone and will be fixed separately. No need for to spin a new version though, Paolo can add the note (or not) if he wants. > Suggested-by: Sean Christopherson > Signed-off-by: Michal Luczaj > --- Reviewed-by: Sean Christopherson